Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1646603004: Move scroll event handlers from layer to layer tree view. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jam, Nate Chapin, kenneth.christiansen, loading-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_cc_listeners
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move scroll event handlers from layer to layer tree view. As similarily done with wheel event handlers move the scroll event handlers to the layer tree view. BUG=489802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968 Cr-Commit-Position: refs/heads/master@{#373112}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase against scroll blocks on #

Total comments: 2

Patch Set 4 : Remove parameter as requested and fix WebPagePopup's Chrome Client #

Patch Set 5 : Ensure WebPagePopup methods are marked with override #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -105 lines) Patch
M cc/blink/web_layer_impl.h View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M cc/debug/debug_rect_history.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M cc/layers/layer.cc View 1 2 5 chunks +0 lines, -12 lines 0 comments Download
M cc/layers/layer_impl.h View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 4 chunks +0 lines, -11 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 2 3 4 chunks +0 lines, -5 lines 0 comments Download
M cc/proto/layer_tree_host.proto View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_json_parser.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/layer_tree_json_parser_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 4 5 5 chunks +12 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 5 chunks +6 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +8 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 2 2 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
dtapuska
4 years, 10 months ago (2016-01-28 16:46:43 UTC) #4
dtapuska
+creis for content/*
4 years, 10 months ago (2016-01-28 22:14:54 UTC) #6
aelias_OOO_until_Jul13
lgtm modulo comment https://codereview.chromium.org/1646603004/diff/40001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1646603004/diff/40001/cc/trees/layer_tree_host_impl.cc#newcode2511 cc/trees/layer_tree_host_impl.cc:2511: *optional_has_ancestor_scroll_handler = true; Please delete this ...
4 years, 10 months ago (2016-01-28 22:25:07 UTC) #7
Charlie Reis
Same rubber stamp LGTM.
4 years, 10 months ago (2016-01-28 23:45:34 UTC) #8
dtapuska
https://codereview.chromium.org/1646603004/diff/40001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1646603004/diff/40001/cc/trees/layer_tree_host_impl.cc#newcode2511 cc/trees/layer_tree_host_impl.cc:2511: *optional_has_ancestor_scroll_handler = true; On 2016/01/28 22:25:07, aelias wrote: > ...
4 years, 10 months ago (2016-01-29 21:23:34 UTC) #9
Rick Byers
WebKit LGTM
4 years, 10 months ago (2016-02-02 20:53:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646603004/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646603004/90001
4 years, 10 months ago (2016-02-02 21:00:18 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 10 months ago (2016-02-03 01:19:56 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 01:21:23 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f024e55c380b2ea3cdb5eb7f52dc922b393d4968
Cr-Commit-Position: refs/heads/master@{#373112}

Powered by Google App Engine
This is Rietveld 408576698