Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1650593002: PPC: Refactor checks for minus zero. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@patch05
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Refactor checks for minus zero. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/21bb9c6a39c86a0db995b74a5fdb2f1df0f5948a Cr-Commit-Position: refs/heads/master@{#33620}

Patch Set 1 #

Patch Set 2 : Fix typos. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -82 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 6 chunks +8 lines, -55 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -16 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +1 line, -11 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 1 chunk +54 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1648353002 Patch 1

Messages

Total messages: 12 (5 generated)
MTBrandyberry
4 years, 10 months ago (2016-01-29 16:22:28 UTC) #1
michael_dawson
On 2016/01/29 16:22:28, MTBrandyberry wrote: lgtm
4 years, 10 months ago (2016-01-29 18:15:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650593002/1
4 years, 10 months ago (2016-01-29 19:55:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650593002/20001
4 years, 10 months ago (2016-01-29 20:09:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 20:40:34 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/21bb9c6a39c86a0db995b74a5fdb2f1df0f5948a Cr-Commit-Position: refs/heads/master@{#33620}
4 years, 10 months ago (2016-01-29 20:40:44 UTC) #11
michael_dawson
4 years, 10 months ago (2016-01-29 20:42:56 UTC) #12
Message was sent while issue was closed. 
On 2016/01/29 20:40:44, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/21bb9c6a39c86a0db995b74a5fdb2f1df0f5948a
> Cr-Commit-Position: refs/heads/master@{#33620}

lgtm

Powered by Google App Engine
This is Rietveld 408576698