Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: src/ppc/builtins-ppc.cc

Issue 1650593002: PPC: Refactor checks for minus zero. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@patch05
Patch Set: Fix typos. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/ppc/macro-assembler-ppc.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ppc/builtins-ppc.cc
diff --git a/src/ppc/builtins-ppc.cc b/src/ppc/builtins-ppc.cc
index 73efb34979f33362baa5ed0e62d596a432f1f654..855dcda632a970d7a66aeab61736d9df5ae85e28 100644
--- a/src/ppc/builtins-ppc.cc
+++ b/src/ppc/builtins-ppc.cc
@@ -215,17 +215,7 @@ void Builtins::Generate_MathMaxMin(MacroAssembler* masm, MathMaxMinKind kind) {
__ b(CommuteCondition(cond_done), &compare_swap);
// Left and right hand side are equal, check for -0 vs. +0.
-#if V8_TARGET_ARCH_PPC64
- __ MovDoubleToInt64(r7, reg);
- __ rotldi(r7, r7, 1);
- __ cmpi(r7, Operand(1));
-#else
- __ MovDoubleToInt64(r7, r8, reg);
- __ cmpi(r8, Operand::Zero());
- __ bne(&loop);
- __ lis(r8, Operand(SIGN_EXT_IMM16(0x8000)));
- __ cmp(r7, r8);
-#endif
+ __ TestDoubleIsMinusZero(reg, r7, r8);
__ bne(&loop);
// Update accumulator. Result is on the right hand side.
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/ppc/macro-assembler-ppc.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698