chrome/browser/ui/cocoa/browser_window_command_handler.mm - Issue 1650483002: Refactor: Untangle Mac's ExclusiveAccessContext from BrowserWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_command_handler.mm

Issue 1650483002: Refactor: Untangle Mac's ExclusiveAccessContext from BrowserWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self nits, More robust interface, fix other random stuff Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_cocoa.mm ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.h » ('j') | chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_command_handler.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_command_handler.mm b/chrome/browser/ui/cocoa/browser_window_command_handler.mm

index 32de3d180cefbdf683e149f20a15cbf0bfaf423b..8697e325dcb7b2e3b1055807088248ce28b2d013 100644

--- a/chrome/browser/ui/cocoa/browser_window_command_handler.mm

+++ b/chrome/browser/ui/cocoa/browser_window_command_handler.mm

@@ -53,7 +53,9 @@ void UpdateToggleStateWithTag(NSInteger tag, id item, NSWindow* window) {

}

if (tag == IDC_TOGGLE_FULLSCREEN_TOOLBAR) {

- SetToggleState(browser->window()->ShouldHideFullscreenToolbar(), item);

+ BrowserWindowController* controller =

+ [browser->window()->GetNativeWindow() windowController];

+ SetToggleState([controller shouldHideFullscreenToolbar], item);

return;

}