Refactor: Untangle Mac's ExclusiveAccessContext from BrowserWindow

chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc

Index: chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc
diff --git a/chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc b/chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc
index c377fdbf0dc476bd39cbd079d77ba4df4164cb71..f7a2f46f17055109d00e37a0f92be56f3dcf989d 100644
--- a/chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc
+++ b/chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc
@@ -13,6 +13,7 @@
 #include "chrome/browser/fullscreen.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ -741,10 +742,12 @@ void FullscreenControllerStateTest::VerifyWindowStateExpectations(
     FullscreenForBrowserExpectation fullscreen_for_browser,
     FullscreenForTabExpectation fullscreen_for_tab,
     InMetroSnapExpectation in_metro_snap) {
+  ExclusiveAccessContext* context =
+      GetBrowser()->window()->GetExclusiveAccessContext();
   if (fullscreen_with_toolbar != FULLSCREEN_WITH_CHROME_NO_EXPECTATION &&
-      GetBrowser()->window()->SupportsFullscreenWithToolbar()) {
-    EXPECT_EQ(GetBrowser()->window()->IsFullscreenWithToolbar(),
-              !!fullscreen_with_toolbar) << GetAndClearDebugLog();
+      context->SupportsFullscreenWithToolbar()) {
+    EXPECT_EQ(context->IsFullscreenWithToolbar(), !!fullscreen_with_toolbar)

[spqchan, 2016/02/01 19:55:04]

Why not just fullscreen_with_toolbar?

[tapted, 2016/02/02 11:57:06]

So this was interesting. FullscreenForBrowserExpectation is an enum with values
FULLSCREEN_FOR_BROWSER_{FALSE, TRUE, NO_EXPECTATION}. `!!` converts
NO_EXPECTATION to ~TRUE (or true), but there doesn't seem to be a need for that
with the `if` condition just above. So I tried that -- it worked fine locally,
but MSVC kicked up a stink on Windows about matching a template with an enum on
one side and a bool on the other.

something like

DCHECK_EQ(IsFullscreen(), fullscreen_with_toolbar ==
FULLSCREEN_FOR_BROWSER_TRUE)

would fix that, but it would make it inconsistent with the surrounding code, so
I've left the `!!` in.

[spqchan, 2016/02/02 22:10:05]

Ah, that makes a lot of sense.

+        << GetAndClearDebugLog();
   }
   if (fullscreen_for_browser != FULLSCREEN_FOR_BROWSER_NO_EXPECTATION) {
     EXPECT_EQ(GetFullscreenController()->IsFullscreenForBrowser(),