third_party/WebKit/Source/core/css/parser/CSSParser.h - Issue 1650473002: Setting selectorText of PageRule accepts invalid selectors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParser.h

Issue 1650473002: Setting selectorText of PageRule accepts invalid selectors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSParser.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParser.h b/third_party/WebKit/Source/core/css/parser/CSSParser.h

index b927202e7946bd6bc4fb8f69484feabee260b270..01b441f9002c57826ff4b66e3082861ced51abeb 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSParser.h

@@ -31,6 +31,7 @@ public:

static PassRefPtrWillBeRawPtr<StyleRuleBase> parseRule(const CSSParserContext&, StyleSheetContents*, const String&);

static void parseSheet(const CSSParserContext&, StyleSheetContents*, const String&);

static CSSSelectorList parseSelector(const CSSParserContext&, StyleSheetContents*, const String&);

+ static CSSSelectorList parsePageSelector(const CSSParserContext&, StyleSheetContents*, const String&);

static bool parseDeclarationList(const CSSParserContext&, MutableStylePropertySet*, const String&);

// Returns whether anything was changed.

static bool parseValue(MutableStylePropertySet*, CSSPropertyID unresolvedProperty, const String&, bool important, StyleSheetContents*);