third_party/WebKit/Source/core/css/parser/CSSParser.h - Issue 1650473002: Setting selectorText of PageRule accepts invalid selectors

Side by Side Diff: third_party/WebKit/Source/core/css/parser/CSSParser.h

Issue 1650473002: Setting selectorText of PageRule accepts invalid selectors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSParser.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CSSParser_h	5 #ifndef CSSParser_h

6 #define CSSParser_h	6 #define CSSParser_h

7	7

8 #include "core/CSSPropertyNames.h"	8 #include "core/CSSPropertyNames.h"

9 #include "core/CoreExport.h"	9 #include "core/CoreExport.h"

10 #include "core/css/CSSValue.h"	10 #include "core/css/CSSValue.h"

(...skipping 13 matching lines...) Expand all Loading...
24 class StyleSheetContents;	24 class StyleSheetContents;

25	25

26 // This class serves as the public API for the css/parser subsystem	26 // This class serves as the public API for the css/parser subsystem

27 class CORE_EXPORT CSSParser {	27 class CORE_EXPORT CSSParser {

28 STATIC_ONLY(CSSParser);	28 STATIC_ONLY(CSSParser);

29 public:	29 public:

30 // As well as regular rules, allows @import and @namespace but not @charset	30 // As well as regular rules, allows @import and @namespace but not @charset

31 static PassRefPtrWillBeRawPtr<StyleRuleBase> parseRule(const CSSParserContex t&, StyleSheetContents*, const String&);	31 static PassRefPtrWillBeRawPtr<StyleRuleBase> parseRule(const CSSParserContex t&, StyleSheetContents*, const String&);

32 static void parseSheet(const CSSParserContext&, StyleSheetContents*, const S tring&);	32 static void parseSheet(const CSSParserContext&, StyleSheetContents*, const S tring&);

33 static CSSSelectorList parseSelector(const CSSParserContext&, StyleSheetCont ents*, const String&);	33 static CSSSelectorList parseSelector(const CSSParserContext&, StyleSheetCont ents*, const String&);

	34 static CSSSelectorList parsePageSelector(const CSSParserContext&, StyleSheet Contents*, const String&);

34 static bool parseDeclarationList(const CSSParserContext&, MutableStyleProper tySet*, const String&);	35 static bool parseDeclarationList(const CSSParserContext&, MutableStyleProper tySet*, const String&);

35 // Returns whether anything was changed.	36 // Returns whether anything was changed.

36 static bool parseValue(MutableStylePropertySet, CSSPropertyID unresolvedPro perty, const String&, bool important, StyleSheetContents);	37 static bool parseValue(MutableStylePropertySet, CSSPropertyID unresolvedPro perty, const String&, bool important, StyleSheetContents);

37	38

38 static bool parseValueForCustomProperty(MutableStylePropertySet, const Atom icString& propertyName, const String& value, bool important, StyleSheetContents );	39 static bool parseValueForCustomProperty(MutableStylePropertySet, const Atom icString& propertyName, const String& value, bool important, StyleSheetContents );

39	40

40 // This is for non-shorthands only	41 // This is for non-shorthands only

41 static PassRefPtrWillBeRawPtr<CSSValue> parseSingleValue(CSSPropertyID, cons t String&, const CSSParserContext& = strictCSSParserContext());	42 static PassRefPtrWillBeRawPtr<CSSValue> parseSingleValue(CSSPropertyID, cons t String&, const CSSParserContext& = strictCSSParserContext());

42	43

43 static PassRefPtrWillBeRawPtr<CSSValue> parseFontFaceDescriptor(CSSPropertyI D, const String&, const CSSParserContext&);	44 static PassRefPtrWillBeRawPtr<CSSValue> parseFontFaceDescriptor(CSSPropertyI D, const String&, const CSSParserContext&);

(...skipping 13 matching lines...) Expand all Loading...
57 static void parseSheetForInspector(const CSSParserContext&, StyleSheetConten ts*, const String&, CSSParserObserver&);	58 static void parseSheetForInspector(const CSSParserContext&, StyleSheetConten ts*, const String&, CSSParserObserver&);

58 static void parseDeclarationListForInspector(const CSSParserContext&, const String&, CSSParserObserver&);	59 static void parseDeclarationListForInspector(const CSSParserContext&, const String&, CSSParserObserver&);

59	60

60 private:	61 private:

61 static bool parseValue(MutableStylePropertySet*, CSSPropertyID unresolvedPro perty, const String&, bool important, const CSSParserContext&);	62 static bool parseValue(MutableStylePropertySet*, CSSPropertyID unresolvedPro perty, const String&, bool important, const CSSParserContext&);

62 };	63 };

63	64

64 } // namespace blink	65 } // namespace blink

65	66

66 #endif // CSSParser_h	67 #endif // CSSParser_h

OLD	NEW