third_party/WebKit/Source/core/css/CSSPageRule.cpp - Issue 1650473002: Setting selectorText of PageRule accepts invalid selectors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPageRule.cpp

Issue 1650473002: Setting selectorText of PageRule accepts invalid selectors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/CSSPageRule.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSPageRule.cpp b/third_party/WebKit/Source/core/css/CSSPageRule.cpp

index e9e3898b1bb19011f58538ca83427375132ec27e..ee6a6003e62fb0b0add9a83c68da965faa0abef9 100644

--- a/third_party/WebKit/Source/core/css/CSSPageRule.cpp

+++ b/third_party/WebKit/Source/core/css/CSSPageRule.cpp

@@ -67,7 +67,7 @@ String CSSPageRule::selectorText() const

void CSSPageRule::setSelectorText(const String& selectorText)

{

CSSParserContext context(parserContext(), 0);

- CSSSelectorList selectorList = CSSParser::parseSelector(context, parentStyleSheet() ? parentStyleSheet()->contents() : nullptr, selectorText);

+ CSSSelectorList selectorList = CSSParser::parsePageSelector(context, parentStyleSheet() ? parentStyleSheet()->contents() : nullptr, selectorText);

if (!selectorList.isValid())

return;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSParser.cpp » ('J')