Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPageRule.cpp

Issue 1650473002: Setting selectorText of PageRule accepts invalid selectors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org) 3 * (C) 2002-2003 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2002, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 String pageSpecification = selector->selectorText(); 60 String pageSpecification = selector->selectorText();
61 if (!pageSpecification.isEmpty()) 61 if (!pageSpecification.isEmpty())
62 text.append(pageSpecification); 62 text.append(pageSpecification);
63 } 63 }
64 return text.toString(); 64 return text.toString();
65 } 65 }
66 66
67 void CSSPageRule::setSelectorText(const String& selectorText) 67 void CSSPageRule::setSelectorText(const String& selectorText)
68 { 68 {
69 CSSParserContext context(parserContext(), 0); 69 CSSParserContext context(parserContext(), 0);
70 CSSSelectorList selectorList = CSSParser::parseSelector(context, parentStyle Sheet() ? parentStyleSheet()->contents() : nullptr, selectorText); 70 CSSSelectorList selectorList = CSSParser::parsePageSelector(context, parentS tyleSheet() ? parentStyleSheet()->contents() : nullptr, selectorText);
71 if (!selectorList.isValid()) 71 if (!selectorList.isValid())
72 return; 72 return;
73 73
74 CSSStyleSheet::RuleMutationScope mutationScope(this); 74 CSSStyleSheet::RuleMutationScope mutationScope(this);
75 75
76 m_pageRule->wrapperAdoptSelectorList(std::move(selectorList)); 76 m_pageRule->wrapperAdoptSelectorList(std::move(selectorList));
77 } 77 }
78 78
79 String CSSPageRule::cssText() const 79 String CSSPageRule::cssText() const
80 { 80 {
(...skipping 21 matching lines...) Expand all
102 } 102 }
103 103
104 DEFINE_TRACE(CSSPageRule) 104 DEFINE_TRACE(CSSPageRule)
105 { 105 {
106 visitor->trace(m_pageRule); 106 visitor->trace(m_pageRule);
107 visitor->trace(m_propertiesCSSOMWrapper); 107 visitor->trace(m_propertiesCSSOMWrapper);
108 CSSRule::trace(visitor); 108 CSSRule::trace(visitor);
109 } 109 }
110 110
111 } // namespace blink 111 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698