Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1650403002: Remove SkBitmapProcStateAutoMapper's overflow check (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkBitmapProcStateAutoMapper's overflow check (follow-up to https://codereview.chromium.org/1642273002) Add an optional SkPoint outparam, and relocate the overflow check to the only client which needs it. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1650403002 Committed: https://skia.googlesource.com/skia/+/8a8eb5242b11ac0b9851b350fbdab0a797ab4a9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M src/core/SkBitmapProcState.h View 2 chunks +6 lines, -14 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 chunk +10 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
f(malita)
4 years, 10 months ago (2016-01-30 19:29:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650403002/1
4 years, 10 months ago (2016-01-30 19:29:33 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-01-30 19:29:34 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 10 months ago (2016-01-31 01:29:02 UTC) #7
reed1
lgtm
4 years, 10 months ago (2016-01-31 02:50:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650403002/1
4 years, 10 months ago (2016-01-31 02:55:47 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-31 02:56:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8a8eb5242b11ac0b9851b350fbdab0a797ab4a9f

Powered by Google App Engine
This is Rietveld 408576698