Add sampler bias for the nofilter/translate specializations

Add sampler bias for the nofilter/translate specializations

Convert SkBitmapProcState::setupForTranslate() to use
SkBitmapProcStateAutoMapper.  This adds bias for the translate procs:
Clamp_S32_D32_nofilter_trans_shaderproc,
Repeat_S32_D32_nofilter_trans_shaderproc

Since the original impl checks for int overflow, extend
SkBitmapProcStateAutoMapper to detect this condition.

BUG=chromium:581870
R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1642273002

Committed: https://skia.googlesource.com/skia/+/653c12d773def4d25cbdb78072b84404a5d80957

[f(malita), 2016-01-28 23:22:16]

Description was changed from

==========
Add sampler bias for the nofilter/translate specializations

Convert SkBitmapProcState::setupForTranslate() to use
SkBitmapProcStateAutoMapper.  This adds bias for the translate procs:
Clamp_S32_D32_nofilter_trans_shaderproc,
Repeat_S32_D32_nofilter_trans_shaderproc

Since the original impl checks for int overflow, extend
SkBitmapProcStateAutoMapper to detect this condition.

BUG=chromium:581870
R=reed@google.com
==========

to

==========
Add sampler bias for the nofilter/translate specializations

Convert SkBitmapProcState::setupForTranslate() to use
SkBitmapProcStateAutoMapper.  This adds bias for the translate procs:
Clamp_S32_D32_nofilter_trans_shaderproc,
Repeat_S32_D32_nofilter_trans_shaderproc

Since the original impl checks for int overflow, extend
SkBitmapProcStateAutoMapper to detect this condition.

BUG=chromium:581870
R=reed@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[f(malita), 2016-01-28 23:26:10]

Moar bias!

We were missing this translate proc bias.  Your patch to no longer ignoring
fractional translation must have changed the proc selection, and exposed this
issue in Chromium at fractional scales.

[f(malita), 2016-01-28 23:26:14]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 23:26:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1642273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1642273002/1

[commit-bot: I haz the power, 2016-01-28 23:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 23:46:10]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-01-28 23:47:53]

This (reassuringly) undoes the slight shift we observed in GM:pictureshader when
you landed your change:
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

[f(malita), 2016-01-29 13:48:29]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 13:48:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1642273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1642273002/20001

[commit-bot: I haz the power, 2016-01-29 14:09:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 14:10:00]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-01-29 19:32:49]

lets add a comment in the header

lgtm

[f(malita), 2016-01-29 19:40:03]

On 2016/01/29 19:32:49, reed1 wrote:
> lets add a comment in the header

Done.  I'll follow up with the cleanup we've discussed.

[f(malita), 2016-01-29 19:40:08]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-01-29 19:40:09]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1642273002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2016-01-29 19:40:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1642273002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1642273002/40001

[commit-bot: I haz the power, 2016-01-30 18:06:48]

Description was changed from

==========
Add sampler bias for the nofilter/translate specializations

Convert SkBitmapProcState::setupForTranslate() to use
SkBitmapProcStateAutoMapper.  This adds bias for the translate procs:
Clamp_S32_D32_nofilter_trans_shaderproc,
Repeat_S32_D32_nofilter_trans_shaderproc

Since the original impl checks for int overflow, extend
SkBitmapProcStateAutoMapper to detect this condition.

BUG=chromium:581870
R=reed@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add sampler bias for the nofilter/translate specializations

Convert SkBitmapProcState::setupForTranslate() to use
SkBitmapProcStateAutoMapper.  This adds bias for the translate procs:
Clamp_S32_D32_nofilter_trans_shaderproc,
Repeat_S32_D32_nofilter_trans_shaderproc

Since the original impl checks for int overflow, extend
SkBitmapProcStateAutoMapper to detect this condition.

BUG=chromium:581870
R=reed@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/653c12d773def4d25cbdb78072b84404a5d80957
==========

[commit-bot: I haz the power, 2016-01-30 18:06:48]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/653c12d773def4d25cbdb78072b84404a5d80957