Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1650233002: [Chromecast][GN] Update Chromecast default rpath. (Closed)

Created:
4 years, 10 months ago by slan
Modified:
4 years, 10 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast][GN] Update Chromecast default rpath. Update default rpath for Chromecast builds to include: * $ORIGIN * $ORIGIN/lib * /oem_cast_shlib Verified by running executables on-device. Our scripts put shared libraries in each of these three places. BUG=516899 Bug: b/17615224 Committed: https://crrev.com/3d909442b74ce4874f3032233b0e08846028c2cb Cr-Commit-Position: refs/heads/master@{#372464}

Patch Set 1 #

Patch Set 2 : Add $ORIGIN/lib, concentrate rpaths. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M build/config/chromecast/BUILD.gn View 1 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
slan
I recently submitted https://codereview.chromium.org/1639343002/, not realizing that we need to put libs in all three ...
4 years, 10 months ago (2016-01-29 22:34:40 UTC) #3
wzhong
lgtm
4 years, 10 months ago (2016-01-29 22:37:06 UTC) #4
Dirk Pranke
lgtm
4 years, 10 months ago (2016-01-29 22:38:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650233002/20001
4 years, 10 months ago (2016-01-29 22:42:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 23:27:54 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 23:29:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d909442b74ce4874f3032233b0e08846028c2cb
Cr-Commit-Position: refs/heads/master@{#372464}

Powered by Google App Engine
This is Rietveld 408576698