Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4224)

Unified Diff: build/config/chromecast/BUILD.gn

Issue 1650233002: [Chromecast][GN] Update Chromecast default rpath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Add $ORIGIN/lib, concentrate rpaths. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/chromecast/BUILD.gn
diff --git a/build/config/chromecast/BUILD.gn b/build/config/chromecast/BUILD.gn
index 4280e9c9ade9397d6a577681402f6f6042cb5919..f1cbfe61946fb68e18ab195dc1e3e9aae4012ad7 100644
--- a/build/config/chromecast/BUILD.gn
+++ b/build/config/chromecast/BUILD.gn
@@ -22,11 +22,16 @@ config("static_config") {
config("ldconfig") {
visibility = [ ":*" ]
- # Chromecast executables depend on several shared libraries in $ORIGIN. Add
- # $ORIGIN to the rpath of these executables. This is not inherited by default
- # when depending on these targets for security reasons (see comments in
- # //build/config/gcc/BUILD.gn)
- configs = [ "//build/config/gcc:rpath_for_built_shared_libraries" ]
+ # Chromecast executables depend on several shared libraries in
+ # /oem_cast_shlib, $ORIGIN, and $ORIGIN/lib. Add these rpaths to each binary.
+ # This is explicitly disabled in Chrome for security reasons (see comments in
+ # //build/config/gcc/BUILD.gn), but necessary on Chromecast so that OEM's may
+ # override the default libraries shipped in the Cast receiver package.
+ ldflags = [
+ "-Wl,-rpath=/oem_cast_shlib",
+ "-Wl,-rpath=\$ORIGIN/lib",
+ "-Wl,-rpath=\$ORIGIN",
+ ]
}
config("executable_config") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698