Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1650033003: Revert of [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase. (patchset #2 id:20001 of https://codereview.chromium.org/1643563002/ ) Reason for revert: [Sheriff] Speculative revert for breaking webkit unit tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/4251 Original issue's description: > [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase. > > BUG= > > Committed: https://crrev.com/85aba7df84d397c7e47537292e6895bd8b26f440 > Cr-Commit-Position: refs/heads/master@{#33613} TBR=ishell@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/0e2854585b3c8bb23290c42b4bb70996835ff175 Cr-Commit-Position: refs/heads/master@{#33615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -33 lines) Patch
M src/api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.h View 1 chunk +13 lines, -12 lines 0 comments Download
M src/objects.cc View 4 chunks +19 lines, -15 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase.
4 years, 10 months ago (2016-01-29 18:48:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650033003/1
4 years, 10 months ago (2016-01-29 18:48:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 18:48:51 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 18:49:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e2854585b3c8bb23290c42b4bb70996835ff175
Cr-Commit-Position: refs/heads/master@{#33615}

Powered by Google App Engine
This is Rietveld 408576698