src/api.cc - Issue 1650033003: Revert of [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1650033003: Revert of [runtime] further dismantle AccessorInfoHandling, reducing it to the single API usecase. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 8830c2b9265c17949bff5e1563fd1b723e4efb94..f259c1c4067faf8d71cdddca9de1cef93fea159b 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3557,8 +3557,7 @@

isolate, js_object, key, &success, i::LookupIterator::OWN);

if (!success) return i::MaybeHandle<i::Object>();

- return i::JSObject::DefineOwnPropertyIgnoreAttributes(

- &it, value, attrs, i::JSObject::FORCE_FIELD);

+ return i::JSObject::DefineOwnPropertyIgnoreAttributes(&it, value, attrs);

}

« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »