[Chromecast] Hook up mojo media pipeline.

[Chromecast] Hook up mojo media pipeline.

The pipeline backend is no-op as of this patch.

BUG=571155
Committed: https://crrev.com/aa2fdfb700402dc9ad4016519b967b3ca86210f1
Cr-Commit-Position: refs/heads/master@{#373374}

[alokp, 2016-01-28 23:31:33]

alokp@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2016-01-29 05:44:13]

Mostly looking good. I just have one question.

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
File chromecast/media/mojo/cast_media_application.h (right):

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
chromecast/media/mojo/cast_media_application.h:14: class CastMediaApplication
Is there any reason Cast can't just use the MojoMediaApplication?

[alokp, 2016-01-29 06:08:36]

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
File chromecast/media/mojo/cast_media_application.h (right):

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
chromecast/media/mojo/cast_media_application.h:14: class CastMediaApplication
On 2016/01/29 05:44:13, xhwang wrote:
> Is there any reason Cast can't just use the MojoMediaApplication?

It could. We either need to figure out how to create CastMediaClient via
MojoMediaClient::Create or perhaps create another target that contains
MojoMediaApplication without the concrete implementation of MojoMediaClient. Do
you have any suggestions?

Although there is not much happening inside MojoMediaApplication. Most of the
logic is implemented in ServiceFactory and various services that we are
re-using.

[xhwang, 2016-01-29 06:50:27]

Description was changed from

==========
[Chromecast] Hook up mojo media pipeline.

The pipeline backend is no-op as of this patch.

BUG=571155
==========

to

==========
[Chromecast] Hook up mojo media pipeline.

The pipeline backend is no-op as of this patch.

BUG=571155
==========

[xhwang, 2016-01-29 07:00:44]

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
File chromecast/media/mojo/cast_media_application.h (right):

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
chromecast/media/mojo/cast_media_application.h:14: class CastMediaApplication
On 2016/01/29 06:08:36, alokp wrote:
> On 2016/01/29 05:44:13, xhwang wrote:
> > Is there any reason Cast can't just use the MojoMediaApplication?
> 
> It could. We either need to figure out how to create CastMediaClient via
> MojoMediaClient::Create or perhaps create another target that contains
> MojoMediaApplication without the concrete implementation of MojoMediaClient.
Do
> you have any suggestions?
> 
> Although there is not much happening inside MojoMediaApplication. Most of the
> logic is implemented in ServiceFactory and various services that we are
> re-using.

+jrummell

We will actually need something similar on desktop where we need a "content"
based MojoMediaClient. So there will be at least four MojoMediaClient
implementations:
1. The current media::DefaultMojoMediaClient will be renamed to
media::TestMojoMediaClient, since it's for test only.
2. media::AndroidMojoMediaClient
3. content::MojoMediaClient for desktop
4. chromecast::media::CastMojoMediaClient

We can probably exclude the MojoMediaClient implementation from the
"application" target. The target that is dependent on "application" should also
depend on a source_set that includes the MojoMediaClient implementation. For
example, in chromecast/media/mojo/BUILD.gn:

     source_set("mojo") {
 11   sources = [
 14     "cast_media_client.cc",
 15     "cast_media_client.h",
 16   ]
 17   deps = [
 18     "//base",
 19     "//media/mojo/interfaces:interfaces_cpp_sources",
 20     "//media/mojo/services:application",
 21     "//mojo/shell/public/cpp",
 22   ]
 23 
 24   public_configs = [ "//media/mojo/services:enable_mojo_media_config" ]
 25 }

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
File chromecast/media/mojo/cast_media_client.h (right):

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
chromecast/media/mojo/cast_media_client.h:10: class CastMediaClient : public
::media::MojoMediaClient {
We actually have media::MediaClient which is different from MojoMediaClient:

https://code.google.com/p/chromium/codesearch#chromium/src/media/base/media_c...

To avoid confusion, this class should probably be named CastMojoMediaClient.

[alokp, 2016-01-29 18:29:25]

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
File chromecast/media/mojo/cast_media_application.h (right):

https://chromiumcodereview.appspot.com/1649933002/diff/20001/chromecast/media...
chromecast/media/mojo/cast_media_application.h:14: class CastMediaApplication
On 2016/01/29 07:00:44, xhwang wrote:
> On 2016/01/29 06:08:36, alokp wrote:
> > On 2016/01/29 05:44:13, xhwang wrote:
> > > Is there any reason Cast can't just use the MojoMediaApplication?
> > 
> > It could. We either need to figure out how to create CastMediaClient via
> > MojoMediaClient::Create or perhaps create another target that contains
> > MojoMediaApplication without the concrete implementation of MojoMediaClient.
> Do
> > you have any suggestions?
> > 
> > Although there is not much happening inside MojoMediaApplication. Most of
the
> > logic is implemented in ServiceFactory and various services that we are
> > re-using.
> 
> +jrummell
> 
> We will actually need something similar on desktop where we need a "content"
> based MojoMediaClient. So there will be at least four MojoMediaClient
> implementations:
> 1. The current media::DefaultMojoMediaClient will be renamed to
> media::TestMojoMediaClient, since it's for test only.
> 2. media::AndroidMojoMediaClient
> 3. content::MojoMediaClient for desktop
> 4. chromecast::media::CastMojoMediaClient
> 
> We can probably exclude the MojoMediaClient implementation from the
> "application" target. The target that is dependent on "application" should
also
> depend on a source_set that includes the MojoMediaClient implementation. For
> example, in chromecast/media/mojo/BUILD.gn:
> 
>      source_set("mojo") {
>  11   sources = [
>  14     "cast_media_client.cc",
>  15     "cast_media_client.h",
>  16   ]
>  17   deps = [
>  18     "//base",
>  19     "//media/mojo/interfaces:interfaces_cpp_sources",
>  20     "//media/mojo/services:application",
>  21     "//mojo/shell/public/cpp",
>  22   ]
>  23 
>  24   public_configs = [ "//media/mojo/services:enable_mojo_media_config" ]
>  25 }

I considered doing that originally but thought it might not be ideal to have to
depend on multiple targets. I will upload a patch shortly with your proposal and
see if you like it any better.

[alokp, 2016-01-29 23:30:35]

Xiaohan: PTAL

[xhwang, 2016-02-01 21:06:18]

Sorry for the delay. I was sick and OOO on Friday.

https://codereview.chromium.org/1649933002/diff/60001/media/mojo/services/def...
File media/mojo/services/default_mojo_media_application.cc (right):

https://codereview.chromium.org/1649933002/diff/60001/media/mojo/services/def...
media/mojo/services/default_mojo_media_application.cc:82: };
This file is more about implementing a MojoMediaClient than implementing an
Application. So I feel I like the original file naming (*_mojo_media_client.*)
better.

Also, I prefer having multiple MojoMediaClient::Create() implementations to
having multiple MojoMediaApplication::CreateApp() implementations. After all, we
only have one MojoMediaApplication implementation, but we have multiple
MojoMediaClient implementations.

[alokp, 2016-02-01 23:17:59]

https://codereview.chromium.org/1649933002/diff/60001/media/mojo/services/def...
File media/mojo/services/default_mojo_media_application.cc (right):

https://codereview.chromium.org/1649933002/diff/60001/media/mojo/services/def...
media/mojo/services/default_mojo_media_application.cc:82: };
On 2016/02/01 21:06:18, xhwang wrote:
> This file is more about implementing a MojoMediaClient than implementing an
> Application. So I feel I like the original file naming (*_mojo_media_client.*)
> better.
> 
> Also, I prefer having multiple MojoMediaClient::Create() implementations to
> having multiple MojoMediaApplication::CreateApp() implementations. After all,
we
> only have one MojoMediaApplication implementation, but we have multiple
> MojoMediaClient implementations.

Done.

[xhwang, 2016-02-02 00:12:27]

https://codereview.chromium.org/1649933002/diff/80001/chromecast/media/mojo/B...
File chromecast/media/mojo/BUILD.gn (right):

https://codereview.chromium.org/1649933002/diff/80001/chromecast/media/mojo/B...
chromecast/media/mojo/BUILD.gn:10: source_set("mojo") {
nit: "mojo" seems too generic. How about something like
"cast_mojo_media_application"?

https://codereview.chromium.org/1649933002/diff/80001/content/gpu/BUILD.gn
File content/gpu/BUILD.gn (left):

https://codereview.chromium.org/1649933002/diff/80001/content/gpu/BUILD.gn#ol...
content/gpu/BUILD.gn:58: }
Why are you making this change? Wondering how will this code work?

https://code.google.com/p/chromium/codesearch#chromium/src/content/gpu/gpu_pr...

https://codereview.chromium.org/1649933002/diff/80001/content/utility/BUILD.gn
File content/utility/BUILD.gn (left):

https://codereview.chromium.org/1649933002/diff/80001/content/utility/BUILD.g...
content/utility/BUILD.gn:36: }
ditto

https://codereview.chromium.org/1649933002/diff/80001/media/mojo/services/moj...
File media/mojo/services/mojo_media_application.h (right):

https://codereview.chromium.org/1649933002/diff/80001/media/mojo/services/moj...
media/mojo/services/mojo_media_application.h:22:
MojoMediaApplication(scoped_ptr<MojoMediaClient> mojo_media_client);
explicit

[alokp, 2016-02-02 00:40:44]

https://codereview.chromium.org/1649933002/diff/80001/chromecast/media/mojo/B...
File chromecast/media/mojo/BUILD.gn (right):

https://codereview.chromium.org/1649933002/diff/80001/chromecast/media/mojo/B...
chromecast/media/mojo/BUILD.gn:10: source_set("mojo") {
On 2016/02/02 00:12:27, xhwang wrote:
> nit: "mojo" seems too generic. How about something like
> "cast_mojo_media_application"?

We reference this as //chromecast/media/mojo, which seems OK. We should use your
suggested name when we switch to the external media mojo application.

https://codereview.chromium.org/1649933002/diff/80001/content/browser/BUILD.gn
File content/browser/BUILD.gn (left):

https://codereview.chromium.org/1649933002/diff/80001/content/browser/BUILD.g...
content/browser/BUILD.gn:523: if (enable_mojo_media != "none") {
I had to make this change to not link the default mojo media application to all
content embedders. It should have been done as part of this patch:
https://codereview.chromium.org/1544853003/

This has been moved to chrome/browser/BUILD.gn. I expected to add a similar
dependency to content/shell/browser, but surprisingly I did not get any link
error when building content_shell with enable_mojo_media="browser". In fact I
discovered that I do not need any of the deps in utility and gpu. I successfully
compiled both chrome and content_shell with various enable_mojo_media configs.

Since you added these deps in the first place, can you tell me what/how I should
build to trigger the need for these deps?

https://codereview.chromium.org/1649933002/diff/80001/content/gpu/BUILD.gn
File content/gpu/BUILD.gn (left):

https://codereview.chromium.org/1649933002/diff/80001/content/gpu/BUILD.gn#ol...
content/gpu/BUILD.gn:58: }
On 2016/02/02 00:12:27, xhwang wrote:
> Why are you making this change? Wondering how will this code work?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/gpu/gpu_pr...

Please see my comment against content/browser/BUILD.gn

https://codereview.chromium.org/1649933002/diff/80001/content/utility/BUILD.gn
File content/utility/BUILD.gn (left):

https://codereview.chromium.org/1649933002/diff/80001/content/utility/BUILD.g...
content/utility/BUILD.gn:36: }
On 2016/02/02 00:12:27, xhwang wrote:
> ditto

ditto

https://codereview.chromium.org/1649933002/diff/80001/media/mojo/services/moj...
File media/mojo/services/mojo_media_application.h (right):

https://codereview.chromium.org/1649933002/diff/80001/media/mojo/services/moj...
media/mojo/services/mojo_media_application.h:22:
MojoMediaApplication(scoped_ptr<MojoMediaClient> mojo_media_client);
On 2016/02/02 00:12:27, xhwang wrote:
> explicit

Done.

[xhwang, 2016-02-02 00:50:12]

https://codereview.chromium.org/1649933002/diff/80001/chromecast/media/mojo/B...
File chromecast/media/mojo/BUILD.gn (right):

https://codereview.chromium.org/1649933002/diff/80001/chromecast/media/mojo/B...
chromecast/media/mojo/BUILD.gn:10: source_set("mojo") {
On 2016/02/02 00:40:44, alokp wrote:
> On 2016/02/02 00:12:27, xhwang wrote:
> > nit: "mojo" seems too generic. How about something like
> > "cast_mojo_media_application"?
> 
> We reference this as //chromecast/media/mojo, which seems OK. We should use
your
> suggested name when we switch to the external media mojo application.

Acknowledged.

https://codereview.chromium.org/1649933002/diff/80001/content/browser/BUILD.gn
File content/browser/BUILD.gn (left):

https://codereview.chromium.org/1649933002/diff/80001/content/browser/BUILD.g...
content/browser/BUILD.gn:523: if (enable_mojo_media != "none") {
On 2016/02/02 00:40:44, alokp wrote:
> I had to make this change to not link the default mojo media application to
all
> content embedders. It should have been done as part of this patch:
> https://codereview.chromium.org/1544853003/
> 
> This has been moved to chrome/browser/BUILD.gn. I expected to add a similar
> dependency to content/shell/browser, but surprisingly I did not get any link
> error when building content_shell with enable_mojo_media="browser". In fact I
> discovered that I do not need any of the deps in utility and gpu. I
successfully
> compiled both chrome and content_shell with various enable_mojo_media configs.
> 
> Since you added these deps in the first place, can you tell me what/how I
should
> build to trigger the need for these deps?

When the target is dependent on the "applicaiton", it'll also expose the
"enable_mojo_media_config" [1], which will define
ENABLE_MOJO_MEDIA_IN_GPU_PROCESS etc [2].

Now you removed the dependency, ENABLE_MOJO_MEDIA_IN_GPU_PROCESS will not be
defined at all. That's how [3] still compiles (I think). But when you try to
connect to the service there will be a connection error.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/mojo/service...

[2]
https://code.google.com/p/chromium/codesearch#chromium/src/media/mojo/service...

[3]
https://code.google.com/p/chromium/codesearch#chromium/src/content/gpu/gpu_pr...

[alokp, 2016-02-02 18:20:35]

On 2016/02/02 00:50:12, xhwang wrote:
>
https://codereview.chromium.org/1649933002/diff/80001/chromecast/media/mojo/B...
> File chromecast/media/mojo/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1649933002/diff/80001/chromecast/media/mojo/B...
> chromecast/media/mojo/BUILD.gn:10: source_set("mojo") {
> On 2016/02/02 00:40:44, alokp wrote:
> > On 2016/02/02 00:12:27, xhwang wrote:
> > > nit: "mojo" seems too generic. How about something like
> > > "cast_mojo_media_application"?
> > 
> > We reference this as //chromecast/media/mojo, which seems OK. We should use
> your
> > suggested name when we switch to the external media mojo application.
> 
> Acknowledged.
> 
> https://codereview.chromium.org/1649933002/diff/80001/content/browser/BUILD.gn
> File content/browser/BUILD.gn (left):
> 
>
https://codereview.chromium.org/1649933002/diff/80001/content/browser/BUILD.g...
> content/browser/BUILD.gn:523: if (enable_mojo_media != "none") {
> On 2016/02/02 00:40:44, alokp wrote:
> > I had to make this change to not link the default mojo media application to
> all
> > content embedders. It should have been done as part of this patch:
> > https://codereview.chromium.org/1544853003/
> > 
> > This has been moved to chrome/browser/BUILD.gn. I expected to add a similar
> > dependency to content/shell/browser, but surprisingly I did not get any link
> > error when building content_shell with enable_mojo_media="browser". In fact
I
> > discovered that I do not need any of the deps in utility and gpu. I
> successfully
> > compiled both chrome and content_shell with various enable_mojo_media
configs.
> > 
> > Since you added these deps in the first place, can you tell me what/how I
> should
> > build to trigger the need for these deps?
> 
> When the target is dependent on the "applicaiton", it'll also expose the
> "enable_mojo_media_config" [1], which will define
> ENABLE_MOJO_MEDIA_IN_GPU_PROCESS etc [2].
> 
> Now you removed the dependency, ENABLE_MOJO_MEDIA_IN_GPU_PROCESS will not be
> defined at all. That's how [3] still compiles (I think). But when you try to
> connect to the service there will be a connection error.
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/mojo/service...
> 
> [2]
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/mojo/service...
> 
> [3]
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/gpu/gpu_pr...

Ah - I missed the enable_mojo_media_config part. Thanks for pointing it out. Now
it all works as expected. PTAL.

[xhwang, 2016-02-02 20:25:16]

Thanks! Just have one question and a few nits.

https://chromiumcodereview.appspot.com/1649933002/diff/140001/chromecast/brow...
File chromecast/browser/cast_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/1649933002/diff/140001/chromecast/brow...
chromecast/browser/cast_content_browser_client.cc:56: #include
"media/mojo/services/mojo_media_application.h"  // nogncheck
cool with "nogncheck" :)

https://chromiumcodereview.appspot.com/1649933002/diff/140001/content/common/...
File content/common/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1649933002/diff/140001/content/common/...
content/common/BUILD.gn:377: deps += [ "//media/mojo/services:cdm_service" ]
Thanks! This path is a bit hacky since we need to access CdmService directly
from C++ code (AVDA). In the future we'll make those decoders part of
MojoMediaApplication, then we won't need this.

https://chromiumcodereview.appspot.com/1649933002/diff/140001/content/shell/b...
File content/shell/browser/shell_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/1649933002/diff/140001/content/shell/b...
content/shell/browser/shell_content_browser_client.cc:67: #endif
What is this for?

https://chromiumcodereview.appspot.com/1649933002/diff/140001/media/mojo/serv...
File media/mojo/services/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1649933002/diff/140001/media/mojo/serv...
media/mojo/services/BUILD.gn:114: public_configs = [ ":enable_mojo_media_config"
]
Can you add a comment that we need this because targets can depend on
cdm_service directly (which is a hack).

https://chromiumcodereview.appspot.com/1649933002/diff/140001/media/mojo/serv...
media/mojo/services/BUILD.gn:128: public_configs = [ ":enable_mojo_media_config"
]
Is this needed by any code today?

[alokp, 2016-02-02 20:37:00]

https://codereview.chromium.org/1649933002/diff/140001/chromecast/browser/cas...
File chromecast/browser/cast_content_browser_client.cc (right):

https://codereview.chromium.org/1649933002/diff/140001/chromecast/browser/cas...
chromecast/browser/cast_content_browser_client.cc:56: #include
"media/mojo/services/mojo_media_application.h"  // nogncheck
On 2016/02/02 20:25:16, xhwang wrote:
> cool with "nogncheck" :)

this is a common pattern in GN for conditional dependencies.

https://codereview.chromium.org/1649933002/diff/140001/content/common/BUILD.gn
File content/common/BUILD.gn (right):

https://codereview.chromium.org/1649933002/diff/140001/content/common/BUILD.g...
content/common/BUILD.gn:377: deps += [ "//media/mojo/services:cdm_service" ]
On 2016/02/02 20:25:16, xhwang wrote:
> Thanks! This path is a bit hacky since we need to access CdmService directly
> from C++ code (AVDA). In the future we'll make those decoders part of
> MojoMediaApplication, then we won't need this.

Acknowledged.

https://codereview.chromium.org/1649933002/diff/140001/content/shell/browser/...
File content/shell/browser/shell_content_browser_client.cc (right):

https://codereview.chromium.org/1649933002/diff/140001/content/shell/browser/...
content/shell/browser/shell_content_browser_client.cc:67: #endif
On 2016/02/02 20:25:16, xhwang wrote:
> What is this for?

Please see my comment below.

https://codereview.chromium.org/1649933002/diff/140001/content/shell/browser/...
content/shell/browser/shell_content_browser_client.cc:228:
apps->insert(std::make_pair(
we need to include media/mojo/services/mojo_media_application.h for this to
compile. I ran into it when compiling content_shell with
enable_mojo_media="browser".

https://codereview.chromium.org/1649933002/diff/140001/media/mojo/services/BU...
File media/mojo/services/BUILD.gn (right):

https://codereview.chromium.org/1649933002/diff/140001/media/mojo/services/BU...
media/mojo/services/BUILD.gn:114: public_configs = [ ":enable_mojo_media_config"
]
On 2016/02/02 20:25:16, xhwang wrote:
> Can you add a comment that we need this because targets can depend on
> cdm_service directly (which is a hack).

Done with a TODO assigned to you :)

https://codereview.chromium.org/1649933002/diff/140001/media/mojo/services/BU...
media/mojo/services/BUILD.gn:128: public_configs = [ ":enable_mojo_media_config"
]
On 2016/02/02 20:25:16, xhwang wrote:
> Is this needed by any code today?

No. I did it for symmetry but I should remove it now given the hacky comment for
cdm_service.

[xhwang, 2016-02-02 20:46:49]

LGTM! Thanks for the cleanup!

https://codereview.chromium.org/1649933002/diff/140001/content/shell/browser/...
File content/shell/browser/shell_content_browser_client.cc (right):

https://codereview.chromium.org/1649933002/diff/140001/content/shell/browser/...
content/shell/browser/shell_content_browser_client.cc:228:
apps->insert(std::make_pair(
On 2016/02/02 20:37:00, alokp wrote:
> we need to include media/mojo/services/mojo_media_application.h for this to
> compile. I ran into it when compiling content_shell with
> enable_mojo_media="browser".

Oh, I forgot about this.

https://codereview.chromium.org/1649933002/diff/140001/media/mojo/services/BU...
File media/mojo/services/BUILD.gn (right):

https://codereview.chromium.org/1649933002/diff/140001/media/mojo/services/BU...
media/mojo/services/BUILD.gn:114: public_configs = [ ":enable_mojo_media_config"
]
On 2016/02/02 20:37:00, alokp wrote:
> On 2016/02/02 20:25:16, xhwang wrote:
> > Can you add a comment that we need this because targets can depend on
> > cdm_service directly (which is a hack).
> 
> Done with a TODO assigned to you :)

Thanks!

[alokp, 2016-02-02 20:57:56]

alokp@chromium.org changed reviewers:
+ halliwell@chromium.org, jam@chromium.org

[alokp, 2016-02-02 20:57:57]

jam: content, chrome
halliwell: chromecast

[jam, 2016-02-02 21:58:39]

lgtm

[halliwell, 2016-02-03 22:12:07]

On 2016/02/02 21:58:39, jam wrote:
> lgtm

lgtm

[alokp, 2016-02-03 22:20:42]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-02-03 22:20:42]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1649933002/#ps200001
(title: "fixed gn check")

[commit-bot: I haz the power, 2016-02-03 22:21:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649933002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649933002/200001

[commit-bot: I haz the power, 2016-02-03 22:56:01]

Description was changed from

==========
[Chromecast] Hook up mojo media pipeline.

The pipeline backend is no-op as of this patch.

BUG=571155
==========

to

==========
[Chromecast] Hook up mojo media pipeline.

The pipeline backend is no-op as of this patch.

BUG=571155
==========

[commit-bot: I haz the power, 2016-02-03 22:56:02]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-02-03 22:57:13]

Description was changed from

==========
[Chromecast] Hook up mojo media pipeline.

The pipeline backend is no-op as of this patch.

BUG=571155
==========

to

==========
[Chromecast] Hook up mojo media pipeline.

The pipeline backend is no-op as of this patch.

BUG=571155

Committed: https://crrev.com/aa2fdfb700402dc9ad4016519b967b3ca86210f1
Cr-Commit-Position: refs/heads/master@{#373374}
==========

[commit-bot: I haz the power, 2016-02-03 22:57:14]

Patchset 11 (id:??) landed as
https://crrev.com/aa2fdfb700402dc9ad4016519b967b3ca86210f1
Cr-Commit-Position: refs/heads/master@{#373374}