chromecast/media/mojo/BUILD.gn - Issue 1649933002: [Chromecast] Hook up mojo media pipeline.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/media/mojo/BUILD.gn

Issue 1649933002: [Chromecast] Hook up mojo media pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//media/media_options.gni")

	6

	7 # We support mojo media service hosted in the browser process only.

	8 assert(enable_mojo_media == "browser")

	9

	10 source_set("mojo") {
	xhwang 2016/02/02 00:12:27 nit: "mojo" seems too generic. How about something nit: "mojo" seems too generic. How about something like "cast_mojo_media_application"? alokp 2016/02/02 00:40:44 We reference this as //chromecast/media/mojo, whic Show quoted text On 2016/02/02 00:12:27, xhwang wrote: > nit: "mojo" seems too generic. How about something like > "cast_mojo_media_application"? We reference this as //chromecast/media/mojo, which seems OK. We should use your suggested name when we switch to the external media mojo application. xhwang 2016/02/02 00:50:12 Acknowledged. Show quoted text On 2016/02/02 00:40:44, alokp wrote: > On 2016/02/02 00:12:27, xhwang wrote: > > nit: "mojo" seems too generic. How about something like > > "cast_mojo_media_application"? > > We reference this as //chromecast/media/mojo, which seems OK. We should use your > suggested name when we switch to the external media mojo application. Acknowledged.
	11 sources = [

	12 "cast_mojo_media_client.cc",

	13 ]

	14

	15 public_deps = [

	16 "//media/mojo/services:application",

	17 ]

	18 public_configs = [ "//media/mojo/services:enable_mojo_media_config" ]

	19 }

OLD	NEW

« no previous file with comments | « chromecast/media/DEPS ('k') | chromecast/media/mojo/cast_mojo_media_client.cc » ('j') | content/browser/BUILD.gn » ('J')