Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: runtime/vm/isolate.cc

Issue 1649843002: Add --warn-on-pause-with-no-debugger flag. Add this to --observe behavior. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review, etc. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index a62ac0ea989415e03b76dcc5f658511fe4edd706..07d09b6b0249bcba14c34250b131d51c21cec3e2 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -84,6 +84,8 @@ DEFINE_FLAG(bool, error_on_bad_override, false,
DEFINE_FLAG(bool, error_on_bad_type, false,
"Report error for malformed types.");
+DECLARE_FLAG(bool, warn_on_pause_with_no_debugger);
+
static void CheckedModeHandler(bool value) {
FLAG_enable_asserts = value;
FLAG_enable_type_checks = value;
@@ -569,7 +571,7 @@ MessageHandler::MessageStatus IsolateMessageHandler::HandleMessage(
void IsolateMessageHandler::NotifyPauseOnStart() {
- if (Service::debug_stream.enabled()) {
+ if (Service::debug_stream.enabled() || FLAG_warn_on_pause_with_no_debugger) {
StartIsolateScope start_isolate(I);
StackZone zone(T);
HandleScope handle_scope(T);
@@ -583,7 +585,7 @@ void IsolateMessageHandler::NotifyPauseOnStart() {
void IsolateMessageHandler::NotifyPauseOnExit() {
- if (Service::debug_stream.enabled()) {
+ if (Service::debug_stream.enabled() || FLAG_warn_on_pause_with_no_debugger) {
StartIsolateScope start_isolate(I);
StackZone zone(T);
HandleScope handle_scope(T);
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698