Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: runtime/vm/debugger.cc

Issue 1649843002: Add --warn-on-pause-with-no-debugger flag. Add this to --observe behavior. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review, etc. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index 1b3d84a97e441602c1a7ec5cce5838387b56109a..4fc7fe6cd24444b1dea6b42e29f94cca9c1937bb 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -44,6 +44,7 @@ DEFINE_FLAG(bool, steal_breakpoints, false,
"the VM service.");
DECLARE_FLAG(bool, trace_isolates);
+DECLARE_FLAG(bool, warn_on_pause_with_no_debugger);
Debugger::EventHandler* Debugger::event_handler_ = NULL;
@@ -281,7 +282,8 @@ static bool ServiceNeedsDebuggerEvent(DebuggerEvent::EventType type) {
case DebuggerEvent::kBreakpointReached:
case DebuggerEvent::kExceptionThrown:
case DebuggerEvent::kIsolateInterrupted:
- return Service::debug_stream.enabled();
+ return (Service::debug_stream.enabled() ||
+ FLAG_warn_on_pause_with_no_debugger);
case DebuggerEvent::kIsolateCreated:
case DebuggerEvent::kIsolateShutdown:
« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698