Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: runtime/bin/main.cc

Issue 1649843002: Add --warn-on-pause-with-no-debugger flag. Add this to --observe behavior. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review, etc. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index 5e57327cc1e86615b5ee397d4445a183419c1877..ee655d2474d3f8563a7b8705a461f165c366a497 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -425,6 +425,8 @@ static bool ProcessObserveOption(const char* option_value,
}
vm_options->AddArgument("--pause-isolates-on-exit");
+ vm_options->AddArgument("--pause-isolates-on-unhandled-exceptions");
+ vm_options->AddArgument("--warn-on-pause-with-no-debugger");
return true;
}
@@ -860,9 +862,11 @@ static void PrintUsage() {
"--packages=<path>\n"
" Where to find a package spec file.\n"
"--observe[=<port>[/<bind-address>]]\n"
-" Enable the VM service and cause isolates to pause on exit (default port is\n"
-" 8181, default bind address is 127.0.0.1). With the default options,\n"
-" Observatory will be available locally at http://127.0.0.1:8181/\n"
+" The observe flag is used to run a program with a default set of options\n"
+" for debugging under Observatory. With the default options, Observatory\n"
+" will be available at http://127.0.0.1:8181/ (default port is 8181,\n"
+" default bind address is 127.0.0.1). Isolates will pause at exit and\n"
+" when they throw unhandled exceptions.\n"
"--version\n"
" Print the VM version.\n");
} else {
@@ -878,9 +882,11 @@ static void PrintUsage() {
"--packages=<path>\n"
" Where to find a package spec file.\n"
"--observe[=<port>[/<bind-address>]]\n"
-" Enable the VM service and cause isolates to pause on exit (default port is\n"
-" 8181, default bind address is 127.0.0.1). With the default options,\n"
-" Observatory will be available locally at http://127.0.0.1:8181/\n"
+" The observe flag is used to run a program with a default set of options\n"
+" for debugging under Observatory. With the default options, Observatory\n"
+" will be available at http://127.0.0.1:8181/ (default port is 8181,\n"
+" default bind address is 127.0.0.1). Isolates will pause at exit and\n"
+" when they throw unhandled exceptions.\n"
"--version\n"
" Print the VM version.\n"
"\n"
@@ -890,9 +896,9 @@ static void PrintUsage() {
"--trace-loading\n"
" enables tracing of library and script loading\n"
"\n"
-"--enable-vm-service[:<port number>]\n"
+"--enable-vm-service[:<port>[/<bind-address>]]\n"
" enables the VM service and listens on specified port for connections\n"
-" (default port number is 8181)\n"
+" (default port number is 8181, default bind address is 127.0.0.1).\n"
"\n"
"The following options are only used for VM development and may\n"
"be changed in any future version:\n");
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698