Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1649843002: Add --warn-on-pause-with-no-debugger flag. Add this to --observe behavior. (Closed)

Created:
4 years, 10 months ago by turnidge
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --warn-on-pause-with-no-debugger flag. Add this to --observe behavior. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/0f1d73fd07c82a947567c8bb1382de72c4ee5a62

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review, etc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -11 lines) Patch
M runtime/bin/main.cc View 1 4 chunks +14 lines, -8 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/service.cc View 1 2 chunks +53 lines, -0 lines 0 comments Download
M runtime/vm/service_event.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 10 months ago (2016-01-28 18:47:34 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1649843002/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/1649843002/diff/1/runtime/bin/main.cc#newcode869 runtime/bin/main.cc:869: " when they receive unhandled exceptions.\n" throw unhandled ...
4 years, 10 months ago (2016-01-28 19:06:56 UTC) #3
turnidge
4 years, 10 months ago (2016-01-29 20:19:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0f1d73fd07c82a947567c8bb1382de72c4ee5a62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698