Port "Eclipse CDT settings" file generation from GYP to GN

Port "Eclipse CDT settings" file generation from GYP to GN

Differences between GN and GYP version:
- GN version does not generate .classpath file because there is a checked in
  version at tools/android/eclipse/.classpath
- GN version does not extract includes dirs and defines from clang compiler.
  A yet to be written python script will do this.

BUG=530676
Committed: https://crrev.com/19ca979da4f9f00296e52beb33f3ecff241852e8
Cr-Commit-Position: refs/heads/master@{#376512}

[pkotwicz, 2016-01-29 02:11:23]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-01-29 02:15:26]

pkotwicz@chromium.org changed reviewers:
+ brettw@chromium.org

[pkotwicz, 2016-01-29 02:15:27]

brettw@ can you please take a look?

This CL depends on https://codereview.chromium.org/1570113002/

[pkotwicz, 2016-01-29 02:16:48]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2016-02-04 02:59:14]

brettw@ Ping!

[pkotwicz, 2016-02-17 16:00:07]

brettw@ Ping!

[brettw, 2016-02-17 18:47:00]

Was out last week, sorry. I'm glad you could re-use so much from the VS
generator, this seems pretty reasonable.

https://codereview.chromium.org/1649783003/diff/60001/tools/gn/command_gen.cc
File tools/gn/command_gen.cc (right):

https://codereview.chromium.org/1649783003/diff/60001/tools/gn/command_gen.cc...
tools/gn/command_gen.cc:201: "      'vs' - Visual Studio project/solution
files.\n"
Update the docs here for your new switch.

Actually, I think it would be good to include some documentation on how it works
here, it seems there are some caveats described in the header file.

I'd add a new section at the bottom

"Eclipse IDE support\n"
"\n"
"  <stuff from the comment here...>

https://codereview.chromium.org/1649783003/diff/60001/tools/gn/eclipse_writer.cc
File tools/gn/eclipse_writer.cc (right):

https://codereview.chromium.org/1649783003/diff/60001/tools/gn/eclipse_writer...
tools/gn/eclipse_writer.cc:48: 
Nit: extra blank.

https://codereview.chromium.org/1649783003/diff/60001/tools/gn/eclipse_writer...
tools/gn/eclipse_writer.cc:106: if (equal_pos == std::string::npos) {
  -DFOO
and
  -DFOO=1
mean different things. I think the define value should be the empty string if
there's no equals.

https://codereview.chromium.org/1649783003/diff/60001/tools/gn/eclipse_writer.h
File tools/gn/eclipse_writer.h (right):

https://codereview.chromium.org/1649783003/diff/60001/tools/gn/eclipse_writer...
tools/gn/eclipse_writer.h:44: // Populates |include_dirs_| with the include dirs
of all the targets for the
There should be a "private:" label somewhere in here.

[pkotwicz, 2016-02-17 20:53:38]

brettw@ can you please take another look?

I believe that I have addressed all of your comments

https://codereview.chromium.org/1649783003/diff/60001/tools/gn/eclipse_writer.h
File tools/gn/eclipse_writer.h (right):

https://codereview.chromium.org/1649783003/diff/60001/tools/gn/eclipse_writer...
tools/gn/eclipse_writer.h:44: // Populates |include_dirs_| with the include dirs
of all the targets for the
The private label is on line 36

[brettw, 2016-02-17 20:59:10]

lgtm

https://codereview.chromium.org/1649783003/diff/80001/tools/gn/command_gen.cc
File tools/gn/command_gen.cc (right):

https://codereview.chromium.org/1649783003/diff/80001/tools/gn/command_gen.cc...
tools/gn/command_gen.cc:204: "  Eclipse IDE Support\n"
For this, can you put this below the "See \"gn help..." comment and format like
so:

  "  See \"gn help switches\" for the common command-line switches.\n"
  "\n"
  "Eclipse IDE Support\n"
  "\n"
  "  GN does not...\n"

Putting the Eclipse heading not indented will trigger heading syntax
highlighting and make the help look prettier, and I think it makes sense to put
this big block outside of the section on switches.

[pkotwicz, 2016-02-18 21:29:35]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-02-18 21:29:36]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1649783003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-02-18 21:34:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649783003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649783003/100001

[commit-bot: I haz the power, 2016-02-18 21:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 21:51:37]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pkotwicz, 2016-02-18 22:40:33]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-02-18 22:40:34]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1649783003/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-02-18 22:46:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649783003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649783003/120001

[tfarina, 2016-02-18 22:54:29]

I'd be happy to make the next gn release with this, but probably Brett will do
:)

Another big milestone for gn and for phasing out gyp.

Thanks,

[commit-bot: I haz the power, 2016-02-18 23:10:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 23:10:48]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2016-02-19 19:05:11]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-02-19 19:06:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1649783003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1649783003/120001

[commit-bot: I haz the power, 2016-02-19 19:39:57]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-02-19 19:40:55]

Description was changed from

==========
Port "Eclipse CDT settings" file generation from GYP to GN

Differences between GN and GYP version:
- GN version does not generate .classpath file because there is a checked in
  version at tools/android/eclipse/.classpath
- GN version does not extract includes dirs and defines from clang compiler.
  A yet to be written python script will do this.

BUG=530676
==========

to

==========
Port "Eclipse CDT settings" file generation from GYP to GN

Differences between GN and GYP version:
- GN version does not generate .classpath file because there is a checked in
  version at tools/android/eclipse/.classpath
- GN version does not extract includes dirs and defines from clang compiler.
  A yet to be written python script will do this.

BUG=530676

Committed: https://crrev.com/19ca979da4f9f00296e52beb33f3ecff241852e8
Cr-Commit-Position: refs/heads/master@{#376512}
==========

[commit-bot: I haz the power, 2016-02-19 19:40:56]

Patchset 5 (id:??) landed as
https://crrev.com/19ca979da4f9f00296e52beb33f3ecff241852e8
Cr-Commit-Position: refs/heads/master@{#376512}

[pkotwicz, 2016-02-19 22:45:53]

tfarina@ it would be awesome if you rolled GN. It looks like there are quite a
few changes to GN since the last roll on Feb 10. I am unsure what the process
for GN rolls is.

[brettw, 2016-02-19 23:01:15]

I tried today but it was reverted to to symbolic link issues. I'll email gn-dev
when we finally get it done.