Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/gn/xml_element_writer_unittest.cc

Issue 1649783003: Port "Eclipse CDT settings" file generation from GYP to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/xml_element_writer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xml_element_writer_unittest.cc
diff --git a/tools/gn/xml_element_writer_unittest.cc b/tools/gn/xml_element_writer_unittest.cc
index 6702061d3c260ae3436466d17870512399d5281e..93dfd47585130b5df9fa0e443519f37da7a33458 100644
--- a/tools/gn/xml_element_writer_unittest.cc
+++ b/tools/gn/xml_element_writer_unittest.cc
@@ -24,27 +24,27 @@ class MockValueWriter {
TEST(XmlElementWriter, EmptyElement) {
std::ostringstream out;
{ XmlElementWriter writer(out, "foo", XmlAttributes()); }
- EXPECT_EQ("<foo/>\n", out.str());
+ EXPECT_EQ("<foo />\n", out.str());
std::ostringstream out_attr;
{
XmlElementWriter writer(out_attr, "foo",
XmlAttributes("bar", "abc").add("baz", "123"));
}
- EXPECT_EQ("<foo bar=\"abc\" baz=\"123\"/>\n", out_attr.str());
+ EXPECT_EQ("<foo bar=\"abc\" baz=\"123\" />\n", out_attr.str());
std::ostringstream out_indent;
{
XmlElementWriter writer(out_indent, "foo", XmlAttributes("bar", "baz"), 2);
}
- EXPECT_EQ(" <foo bar=\"baz\"/>\n", out_indent.str());
+ EXPECT_EQ(" <foo bar=\"baz\" />\n", out_indent.str());
std::ostringstream out_writer;
{
XmlElementWriter writer(out_writer, "foo", "bar", MockValueWriter("baz"),
2);
}
- EXPECT_EQ(" <foo bar=\"baz\"/>\n", out_writer.str());
+ EXPECT_EQ(" <foo bar=\"baz\" />\n", out_writer.str());
}
TEST(XmlElementWriter, ElementWithText) {
@@ -67,10 +67,10 @@ TEST(XmlElementWriter, SubElements) {
}
std::string expected =
"<root aaa=\"000\">\n"
- " <foo/>\n"
+ " <foo />\n"
" <bar bbb=\"111\">hello</bar>\n"
" <baz ccc=\"222\">\n"
- " <grandchild/>\n"
+ " <grandchild />\n"
" </baz>\n"
"</root>\n";
EXPECT_EQ(expected, out.str());
« no previous file with comments | « tools/gn/xml_element_writer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698