Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1649753002: Revert of Insist on a Blink GC on RenderViewImpl unit test teardowns. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Insist on a Blink GC on RenderViewImpl unit test teardowns. (patchset #1 id:1 of https://codereview.chromium.org/1621823004/ ) Reason for revert: Rolling this one out, going with https://codereview.chromium.org/1645923002/ 's approach instead. Original issue's description: > Insist on a Blink GC on RenderViewImpl unit test teardowns. > > Without it, flaky LSan reports are a risk, depending on GC timing and > on tests allowing posted GC tasks to be processed before many of them > abruptly clear posted messages as part of their operation. > > R=haraken > TBR=jochen > BUG= > > Committed: https://crrev.com/ca438fc0e1e6731a6bebee4e298f8e5dd7da44fa > Cr-Commit-Position: refs/heads/master@{#371169} TBR=haraken@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M content/renderer/render_view_browsertest.cc View 4 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sof
Created Revert of Insist on a Blink GC on RenderViewImpl unit test teardowns.
4 years, 10 months ago (2016-01-28 12:39:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649753002/1
4 years, 10 months ago (2016-01-28 12:40:06 UTC) #2
sof
4 years, 10 months ago (2016-01-28 12:46:42 UTC) #4
Stopped; taking this through CQ will just create lag & ASan flakes while doing
so. Unnecessary overhead.

Reverting it as part of https://codereview.chromium.org/1645923002/ instead.

Powered by Google App Engine
This is Rietveld 408576698