Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1649663003: Add basic support for a configuration file. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add basic support for a configuration file. This just loads a subset of the config that can be pased on the command line from the configuration file. The command line takes precedence over the config. See #46 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/fe0b4ce81fdcad810ecd07855afb0893b1257dcd

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1256 lines, -210 lines) Patch
M README.md View 1 2 chunks +26 lines, -0 lines 0 comments Download
A dart_test.yaml View 1 1 chunk +2 lines, -0 lines 0 comments Download
A doc/package_config.md View 1 2 1 chunk +116 lines, -0 lines 0 comments Download
M lib/src/executable.dart View 1 2 chunks +20 lines, -0 lines 0 comments Download
M lib/src/runner/configuration.dart View 1 2 chunks +103 lines, -199 lines 0 comments Download
A lib/src/runner/configuration/args.dart View 1 1 chunk +177 lines, -0 lines 1 comment Download
A lib/src/runner/configuration/load.dart View 1 1 chunk +156 lines, -0 lines 0 comments Download
A lib/src/runner/configuration/values.dart View 1 1 chunk +22 lines, -0 lines 0 comments Download
M lib/src/util/io.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M lib/src/utils.dart View 1 2 chunks +7 lines, -0 lines 0 comments Download
M test/io.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
A test/runner/configuration/configuration_test.dart View 1 1 chunk +217 lines, -0 lines 1 comment Download
A test/runner/configuration/top_level_error_test.dart View 1 1 chunk +164 lines, -0 lines 1 comment Download
A test/runner/configuration/top_level_test.dart View 1 1 chunk +235 lines, -0 lines 1 comment Download
M test/runner/pub_serve_test.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/runner/runner_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
nweiz
4 years, 10 months ago (2016-02-03 20:29:38 UTC) #3
kevmoo
LGTM https://codereview.chromium.org/1649663003/diff/40001/lib/src/runner/configuration/args.dart File lib/src/runner/configuration/args.dart (right): https://codereview.chromium.org/1649663003/diff/40001/lib/src/runner/configuration/args.dart#newcode64 lib/src/runner/configuration/args.dart:64: defaultsTo: defaultConcurrency, defaultConcurrency must be a String https://codereview.chromium.org/1649663003/diff/40001/test/runner/configuration/configuration_test.dart ...
4 years, 10 months ago (2016-02-03 23:01:56 UTC) #4
nweiz
4 years, 10 months ago (2016-02-04 00:07:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
fe0b4ce81fdcad810ecd07855afb0893b1257dcd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698