Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1649573002: Refactored kTestString occurences in bridged_native_widget_unittest.mm (Closed)

Created:
4 years, 10 months ago by karandeepb
Modified:
4 years, 10 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored kTestString occurences in bridged_native_widget_unittest.mm As per the CPP style guide, variables declared constexpr or const, and whose value is fixed for the duration of the program, are named with a leading "k" followed by mixed case. Since objects don't have a constant value for the duration of the program, refactor "kTestString" to "test_string". Committed: https://crrev.com/3f2f74e670e0bf65ee92a6c8da2e88cef47e7b6e Cr-Commit-Position: refs/heads/master@{#372042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M ui/views/cocoa/bridged_native_widget_unittest.mm View 8 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
karandeepb
PTAL Trent. This is a follow up refactor CL relating to our discussion in https://codereview.chromium.org/1531213002/.
4 years, 10 months ago (2016-01-28 06:33:15 UTC) #3
tapted
thanks! lgtm
4 years, 10 months ago (2016-01-28 07:18:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649573002/1
4 years, 10 months ago (2016-01-28 07:23:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 07:28:59 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 07:30:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f2f74e670e0bf65ee92a6c8da2e88cef47e7b6e
Cr-Commit-Position: refs/heads/master@{#372042}

Powered by Google App Engine
This is Rietveld 408576698