Refactored kTestString occurences in bridged_native_widget_unittest.mm

ui/views/cocoa/bridged_native_widget_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_native_widget.h"
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/foundation_util.h"
 #import "base/mac/mac_util.h"
@@ skipping 412 matching lines @@
   InstallTextField(test_string, ui::TEXT_INPUT_TYPE_TEXT);
   EXPECT_TRUE([ns_view_ inputContext]);
   [ns_view_ setTextInputClient:nil];
   EXPECT_FALSE([ns_view_ inputContext]);
   InstallTextField(test_string, ui::TEXT_INPUT_TYPE_NONE);
   EXPECT_FALSE([ns_view_ inputContext]);
 }
 
 // Test getting complete string using text input protocol.
 TEST_F(BridgedNativeWidgetTest, TextInput_GetCompleteString) {
-  const std::string kTestString = "foo bar baz";
-  InstallTextField(kTestString);
+  const std::string test_string = "foo bar baz";
+  InstallTextField(test_string);
 
-  NSRange range = NSMakeRange(0, kTestString.size());
+  NSRange range = NSMakeRange(0, test_string.size());
   NSRange actual_range;
   NSAttributedString* text =
       [ns_view_ attributedSubstringForProposedRange:range
                                         actualRange:&actual_range];
-  EXPECT_EQ(kTestString, SysNSStringToUTF8([text string]));
+  EXPECT_EQ(test_string, SysNSStringToUTF8([text string]));
   EXPECT_EQ_RANGE(range, actual_range);
 }
 
 // Test getting middle substring using text input protocol.
 TEST_F(BridgedNativeWidgetTest, TextInput_GetMiddleSubstring) {
-  const std::string kTestString = "foo bar baz";
-  InstallTextField(kTestString);
+  const std::string test_string = "foo bar baz";
+  InstallTextField(test_string);
 
   NSRange range = NSMakeRange(4, 3);
   NSRange actual_range;
   NSAttributedString* text =
       [ns_view_ attributedSubstringForProposedRange:range
                                         actualRange:&actual_range];
   EXPECT_EQ("bar", SysNSStringToUTF8([text string]));
   EXPECT_EQ_RANGE(range, actual_range);
 }
 
 // Test getting ending substring using text input protocol.
 TEST_F(BridgedNativeWidgetTest, TextInput_GetEndingSubstring) {
-  const std::string kTestString = "foo bar baz";
-  InstallTextField(kTestString);
+  const std::string test_string = "foo bar baz";
+  InstallTextField(test_string);
 
   NSRange range = NSMakeRange(8, 100);
   NSRange actual_range;
   NSAttributedString* text =
       [ns_view_ attributedSubstringForProposedRange:range
                                         actualRange:&actual_range];
   EXPECT_EQ("baz", SysNSStringToUTF8([text string]));
   EXPECT_EQ(range.location, actual_range.location);
   EXPECT_EQ(3U, actual_range.length);
 }
 
 // Test getting empty substring using text input protocol.
 TEST_F(BridgedNativeWidgetTest, TextInput_GetEmptySubstring) {
-  const std::string kTestString = "foo bar baz";
-  InstallTextField(kTestString);
+  const std::string test_string = "foo bar baz";
+  InstallTextField(test_string);
 
   NSRange range = EmptyRange();
   NSRange actual_range;
   NSAttributedString* text =
       [ns_view_ attributedSubstringForProposedRange:range
                                         actualRange:&actual_range];
   EXPECT_EQ("", SysNSStringToUTF8([text string]));
   EXPECT_EQ_RANGE(range, actual_range);
 }
 
 // Test inserting text using text input protocol.
 TEST_F(BridgedNativeWidgetTest, TextInput_InsertText) {
-  const std::string kTestString = "foo";
-  InstallTextField(kTestString);
+  const std::string test_string = "foo";
+  InstallTextField(test_string);
 
-  [ns_view_ insertText:SysUTF8ToNSString(kTestString)
+  [ns_view_ insertText:SysUTF8ToNSString(test_string)
       replacementRange:EmptyRange()];
-  gfx::Range range(0, kTestString.size());
+  gfx::Range range(0, test_string.size());
   base::string16 text;
   EXPECT_TRUE([ns_view_ textInputClient]->GetTextFromRange(range, &text));
-  EXPECT_EQ(ASCIIToUTF16(kTestString), text);
+  EXPECT_EQ(ASCIIToUTF16(test_string), text);
 }
 
 // Test replacing text using text input protocol.
 TEST_F(BridgedNativeWidgetTest, TextInput_ReplaceText) {
-  const std::string kTestString = "foo bar";
-  InstallTextField(kTestString);
+  const std::string test_string = "foo bar";
+  InstallTextField(test_string);
 
   [ns_view_ insertText:@"baz" replacementRange:NSMakeRange(4, 3)];
   EXPECT_EQ("foo baz", GetText());
 }
 
 // Test IME composition using text input protocol.
 TEST_F(BridgedNativeWidgetTest, TextInput_Compose) {
-  const std::string kTestString = "foo ";
-  InstallTextField(kTestString);
+  const std::string test_string = "foo ";
+  InstallTextField(test_string);
 
   EXPECT_FALSE([ns_view_ hasMarkedText]);
   EXPECT_EQ_RANGE(EmptyRange(), [ns_view_ markedRange]);
 
   // Start composition.
   NSString* compositionText = @"bar";
   NSUInteger compositionLength = [compositionText length];
   [ns_view_ setMarkedText:compositionText
             selectedRange:NSMakeRange(0, 2)
          replacementRange:EmptyRange()];
   EXPECT_TRUE([ns_view_ hasMarkedText]);
-  EXPECT_EQ_RANGE(NSMakeRange(kTestString.size(), compositionLength),
+  EXPECT_EQ_RANGE(NSMakeRange(test_string.size(), compositionLength),
                   [ns_view_ markedRange]);
-  EXPECT_EQ_RANGE(NSMakeRange(kTestString.size(), 2), [ns_view_ selectedRange]);
+  EXPECT_EQ_RANGE(NSMakeRange(test_string.size(), 2), [ns_view_ selectedRange]);
 
   // Confirm composition.
   [ns_view_ unmarkText];
   EXPECT_FALSE([ns_view_ hasMarkedText]);
   EXPECT_EQ_RANGE(EmptyRange(), [ns_view_ markedRange]);
   EXPECT_EQ("foo bar", GetText());
   EXPECT_EQ_RANGE(NSMakeRange(GetText().size(), 0), [ns_view_ selectedRange]);
 }
 
 // Test moving the caret left and right using text input protocol.
@@ skipping 108 matching lines @@
   // Make sure not crashing by passing null pointer instead of actualRange.
   rect = [ns_view_ firstRectForCharacterRange:query_range actualRange:nullptr];
 }
 
 // Test firstRectForCharacterRange:actualRange for non-empty query ranges within
 // the composition range.
 TEST_F(BridgedNativeWidgetTest, TextInput_FirstRectForCharacterRange) {
   InstallTextField("");
   ui::TextInputClient* client = [ns_view_ textInputClient];
 
-  const base::string16 kTestString = base::ASCIIToUTF16("test_str");
+  const base::string16 test_string = base::ASCIIToUTF16("test_str");
   const size_t kTextLength = 8;
-  SetCompositionText(client, kTestString, 1, nullptr);
+  SetCompositionText(client, test_string, 1, nullptr);
 
   // Query bounds for the whole composition string.
   NSRange query_range = NSMakeRange(0, kTextLength);
   NSRange actual_range;
   NSRect rect = [ns_view_ firstRectForCharacterRange:query_range
                                          actualRange:&actual_range];
-  EXPECT_EQ(GetExpectedBoundsForRange(client, kTestString, query_range),
+  EXPECT_EQ(GetExpectedBoundsForRange(client, test_string, query_range),
             gfx::ScreenRectFromNSRect(rect));
   EXPECT_EQ_RANGE(query_range, actual_range);
 
   // Query bounds for the substring "est_".
   query_range = NSMakeRange(1, 4);
   rect = [ns_view_ firstRectForCharacterRange:query_range
                                   actualRange:&actual_range];
-  EXPECT_EQ(GetExpectedBoundsForRange(client, kTestString, query_range),
+  EXPECT_EQ(GetExpectedBoundsForRange(client, test_string, query_range),
             gfx::ScreenRectFromNSRect(rect));
   EXPECT_EQ_RANGE(query_range, actual_range);
 }
 
 typedef BridgedNativeWidgetTestBase BridgedNativeWidgetSimulateFullscreenTest;
 
 // Simulate the notifications that AppKit would send out if a fullscreen
 // operation begins, and then fails and must abort. This notification sequence
 // was determined by posting delayed tasks to toggle fullscreen state and then
 // mashing Ctrl+Left/Right to keep OSX in a transition between Spaces to cause
@@ skipping 62 matching lines @@
   [center postNotificationName:NSWindowDidExitFullScreenNotification
                         object:window];
   EXPECT_EQ(1, [window ignoredToggleFullScreenCount]);  // No change.
   EXPECT_FALSE(bridge()->target_fullscreen_state());
 
   widget_->CloseNow();
 }
 
 }  // namespace test
 }  // namespace views