Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1649513003: Editing: Minor improvement of ReplaceSelectionCommand (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing: Minor improvement of ReplaceSelectionCommand - Tighten up he second argument of moveElementOutOfAncestor(); ContainerNode -> Element - Add inDocument() check in makeInsertedContentRoundTrippableWithHTMLTreeBuild(). crrev.com/371774 fixed one such case. However we still might have such cases. Add inDocument() check just in case in order to avoid future crashes. BUG=537815 Committed: https://crrev.com/8f28f81f237b61372089dffc331991d465a823d7 Cr-Commit-Position: refs/heads/master@{#372018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
yosin@, would you review this please?
4 years, 11 months ago (2016-01-28 04:22:08 UTC) #2
yosin_UTC9
lgtm
4 years, 11 months ago (2016-01-28 04:31:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649513003/1
4 years, 11 months ago (2016-01-28 04:33:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 05:08:04 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 05:08:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f28f81f237b61372089dffc331991d465a823d7
Cr-Commit-Position: refs/heads/master@{#372018}

Powered by Google App Engine
This is Rietveld 408576698