Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h

Issue 1649513003: Editing: Minor improvement of ReplaceSelectionCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 bool shouldMergeStart(bool, bool, bool); 88 bool shouldMergeStart(bool, bool, bool);
89 bool shouldMergeEnd(bool selectionEndWasEndOfParagraph); 89 bool shouldMergeEnd(bool selectionEndWasEndOfParagraph);
90 bool shouldMerge(const VisiblePosition&, const VisiblePosition&); 90 bool shouldMerge(const VisiblePosition&, const VisiblePosition&);
91 91
92 void mergeEndIfNeeded(); 92 void mergeEndIfNeeded();
93 93
94 void removeUnrenderedTextNodesAtEnds(InsertedNodes&); 94 void removeUnrenderedTextNodesAtEnds(InsertedNodes&);
95 95
96 void removeRedundantStylesAndKeepStyleSpanInline(InsertedNodes&); 96 void removeRedundantStylesAndKeepStyleSpanInline(InsertedNodes&);
97 void makeInsertedContentRoundTrippableWithHTMLTreeBuilder(const InsertedNode s&); 97 void makeInsertedContentRoundTrippableWithHTMLTreeBuilder(const InsertedNode s&);
98 void moveElementOutOfAncestor(PassRefPtrWillBeRawPtr<Element>, PassRefPtrWil lBeRawPtr<ContainerNode> ancestor); 98 void moveElementOutOfAncestor(PassRefPtrWillBeRawPtr<Element>, PassRefPtrWil lBeRawPtr<Element> ancestor);
99 void handleStyleSpans(InsertedNodes&); 99 void handleStyleSpans(InsertedNodes&);
100 100
101 VisiblePosition positionAtStartOfInsertedContent() const; 101 VisiblePosition positionAtStartOfInsertedContent() const;
102 VisiblePosition positionAtEndOfInsertedContent() const; 102 VisiblePosition positionAtEndOfInsertedContent() const;
103 103
104 bool shouldPerformSmartReplace() const; 104 bool shouldPerformSmartReplace() const;
105 void addSpacesForSmartReplace(); 105 void addSpacesForSmartReplace();
106 void completeHTMLReplacement(const Position& lastPositionToSelect); 106 void completeHTMLReplacement(const Position& lastPositionToSelect);
107 void mergeTextNodesAroundPosition(Position&, Position& positionOnlyToBeUpdat ed); 107 void mergeTextNodesAroundPosition(Position&, Position& positionOnlyToBeUpdat ed);
108 108
(...skipping 14 matching lines...) Expand all
123 123
124 Position m_startOfInsertedRange; 124 Position m_startOfInsertedRange;
125 Position m_endOfInsertedRange; 125 Position m_endOfInsertedRange;
126 }; 126 };
127 127
128 DEFINE_TYPE_CASTS(ReplaceSelectionCommand, CompositeEditCommand, command, comman d->isReplaceSelectionCommand(), command.isReplaceSelectionCommand()); 128 DEFINE_TYPE_CASTS(ReplaceSelectionCommand, CompositeEditCommand, command, comman d->isReplaceSelectionCommand(), command.isReplaceSelectionCommand());
129 129
130 } // namespace blink 130 } // namespace blink
131 131
132 #endif // ReplaceSelectionCommand_h 132 #endif // ReplaceSelectionCommand_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698