Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: webkit/common/appcache/appcache_interfaces.cc

Issue 164933002: Expose details for appcache error events [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't leak details cross-origin Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/common/appcache/appcache_interfaces.cc
diff --git a/webkit/common/appcache/appcache_interfaces.cc b/webkit/common/appcache/appcache_interfaces.cc
index ca43f3577882d9f513bfa702e751eab78c81a517..13a06f34eaa0bead11962c922763d6ffa0e578ff 100644
--- a/webkit/common/appcache/appcache_interfaces.cc
+++ b/webkit/common/appcache/appcache_interfaces.cc
@@ -49,6 +49,26 @@ AppCacheResourceInfo::AppCacheResourceInfo()
AppCacheResourceInfo::~AppCacheResourceInfo() {
}
+ErrorDetails::ErrorDetails()
+ : message(),
+ reason(UNKNOWN_ERROR),
+ url(),
+ status(0),
+ is_cross_origin(false) {}
+
+ErrorDetails::ErrorDetails(std::string in_message,
+ ErrorReason in_reason,
+ GURL in_url,
+ int in_status,
+ bool in_is_cross_origin)
michaeln 2014/03/27 01:05:37 nit: indent looks funky, maybe back the arglist up
jsbell 2014/03/27 19:23:23 Done. I blame clang format.
+ : message(in_message),
+ reason(in_reason),
+ url(in_url),
+ status(in_status),
+ is_cross_origin(in_is_cross_origin) {}
+
+ErrorDetails::~ErrorDetails() {}
+
Namespace::Namespace()
: type(FALLBACK_NAMESPACE),
is_pattern(false),

Powered by Google App Engine
This is Rietveld 408576698