Expose details for appcache error events [Chromium]

webkit/common/appcache/appcache_interfaces.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/common/appcache/appcache_interfaces.h"
 
 #include <set>
 
 #include "base/strings/string_util.h"
 #include "net/url_request/url_request.h"
@@ skipping 31 matching lines @@
       is_intercept(false),
       is_fallback(false),
       is_foreign(false),
       is_explicit(false),
       response_id(kNoResponseId) {
 }
 
 AppCacheResourceInfo::~AppCacheResourceInfo() {
 }
 
+ErrorDetails::ErrorDetails()
+    : message(),
+      reason(UNKNOWN_ERROR),
+      url(),
+      status(0),
+      is_cross_origin(false) {}
+
+ErrorDetails::ErrorDetails(std::string in_message,
+                           ErrorReason in_reason,
+                           GURL in_url,
+                           int in_status,
+                           bool in_is_cross_origin)

[michaeln, 2014/03/27 01:05:37]

nit: indent looks funky, maybe back the arglist up to 4 spaces in from method
sig?

[jsbell, 2014/03/27 19:23:23]

Done. I blame clang format.

+    : message(in_message),
+      reason(in_reason),
+      url(in_url),
+      status(in_status),
+      is_cross_origin(in_is_cross_origin) {}
+
+ErrorDetails::~ErrorDetails() {}
+
 Namespace::Namespace()
     : type(FALLBACK_NAMESPACE),
       is_pattern(false),
       is_executable(false) {
 }
 
 Namespace::Namespace(
     NamespaceType type, const GURL& url, const GURL& target, bool is_pattern)
     : type(type),
       namespace_url(url),
@@ skipping 46 matching lines @@
 bool IsMethodSupported(const std::string& method) {
   return (method == kHttpGETMethod) || (method == kHttpHEADMethod);
 }
 
 bool IsSchemeAndMethodSupported(const net::URLRequest* request) {
   return IsSchemeSupported(request->url()) &&
          IsMethodSupported(request->method());
 }
 
 }  // namespace appcache