webkit/browser/appcache/appcache_update_job_unittest.cc - Issue 164933002: Expose details for appcache error events [Chromium]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/browser/appcache/appcache_update_job_unittest.cc

Issue 164933002: Expose details for appcache error events [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't leak details cross-origin Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/browser/appcache/appcache_update_job_unittest.cc

diff --git a/webkit/browser/appcache/appcache_update_job_unittest.cc b/webkit/browser/appcache/appcache_update_job_unittest.cc

index ba3cf9abcabdb4f27ad7f32ccbcd795c19351fc7..c7c9e418d46df61168e753d3ee89b494c76bc486 100644

--- a/webkit/browser/appcache/appcache_update_job_unittest.cc

+++ b/webkit/browser/appcache/appcache_update_job_unittest.cc

@@ -243,8 +243,9 @@ class MockFrontend : public AppCacheFrontend {

}

virtual void OnErrorEventRaised(const std::vector<int>& host_ids,

- const std::string& message) OVERRIDE {

- error_message_ = message;

+ const appcache::ErrorDetails& details)

+ OVERRIDE {

+ error_message_ = details.message;

OnEventRaised(host_ids, ERROR_EVENT);

}