Expose details for appcache error events [Chromium]

webkit/common/appcache/appcache_interfaces.h

Index: webkit/common/appcache/appcache_interfaces.h
diff --git a/webkit/common/appcache/appcache_interfaces.h b/webkit/common/appcache/appcache_interfaces.h
index b631728528af82271281c79b78572a06219b1e96..45314aa7a424050ef11c4d756ee896677abfc4da 100644
--- a/webkit/common/appcache/appcache_interfaces.h
+++ b/webkit/common/appcache/appcache_interfaces.h
@@ -64,6 +64,18 @@ enum NamespaceType {
   NETWORK_NAMESPACE
 };
 
+enum ErrorReason {
+  ERROR_MANIFEST_FETCH,
+  ERROR_MANIFEST_INVALID,
+  ERROR_MANIFEST_CHANGED,
+  ERROR_MANIFEST_OBSOLETE,
+  ERROR_RESOURCE_FETCH,
+  ERROR_QUOTA_EXCEEDED,
+  ERROR_POLICY,
+  ERROR_INTERNAL,
+  ERROR_LAST = ERROR_INTERNAL

[michaeln, 2014/02/27 23:16:06]

I'm looking at this set of Reasons and comparing to the set of ResultTypes we
log in UMA. I think your high level reasons look pretty good, but the lower
level distinctions would be nice to convey since a fetch operation can fail for
a variety of reasons.

 enum ErrorReason {
  68   ERROR_MANIFEST_FETCH,
  69   ERROR_MANIFEST_INVALID,
  70   ERROR_MANIFEST_CHANGED,
  71   ERROR_MANIFEST_OBSOLETE,
  72   ERROR_RESOURCE_FETCH,
  73   ERROR_QUOTA_EXCEEDED,
  74   ERROR_POLICY,
  75   ERROR_INTERNAL,  // this pretty much means failed to read/write disk

  enum ResultType {
    UPDATE_OK,
    DB_ERROR,
    DISKCACHE_ERROR,
    QUOTA_ERROR,
    REDIRECT_ERROR,
    MANIFEST_ERROR,
    NETWORK_ERROR,
    SERVER_ERROR,
  };

[jsbell, 2014/02/28 22:46:00]

Agreed, see discussion under ERROR_RESOURCE_FETCH

+};
+
 struct WEBKIT_STORAGE_COMMON_EXPORT AppCacheInfo {
   AppCacheInfo();
   ~AppCacheInfo();
@@ -131,7 +143,10 @@ class WEBKIT_STORAGE_COMMON_EXPORT AppCacheFrontend {
                                      const GURL& url,
                                      int num_total, int num_complete) = 0;
   virtual void OnErrorEventRaised(const std::vector<int>& host_ids,
-                                  const std::string& message) = 0;
+                                  const std::string& message,
+                                  appcache::ErrorReason reason,
+                                  const GURL& url,
+                                  int status) = 0;
   virtual void OnContentBlocked(int host_id,
                                 const GURL& manifest_url) = 0;
   virtual void OnLogMessage(int host_id, LogLevel log_level,