Expose details for appcache error events [Chromium]

webkit/common/appcache/appcache_interfaces.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_COMMON_APPCACHE_APPCACHE_INTERFACES_H_
 #define WEBKIT_COMMON_APPCACHE_APPCACHE_INTERFACES_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 46 matching lines @@
   LOG_WARNING = 2,
   LOG_ERROR = 3,
 };
 
 enum NamespaceType {
   FALLBACK_NAMESPACE,
   INTERCEPT_NAMESPACE,
   NETWORK_NAMESPACE
 };
 
+enum ErrorReason {
+  ERROR_MANIFEST_FETCH,
+  ERROR_MANIFEST_INVALID,
+  ERROR_MANIFEST_CHANGED,
+  ERROR_MANIFEST_OBSOLETE,
+  ERROR_RESOURCE_FETCH,
+  ERROR_QUOTA_EXCEEDED,
+  ERROR_POLICY,
+  ERROR_INTERNAL,
+  ERROR_LAST = ERROR_INTERNAL

[michaeln, 2014/02/27 23:16:06]

I'm looking at this set of Reasons and comparing to the set of ResultTypes we
log in UMA. I think your high level reasons look pretty good, but the lower
level distinctions would be nice to convey since a fetch operation can fail for
a variety of reasons.

 enum ErrorReason {
  68   ERROR_MANIFEST_FETCH,
  69   ERROR_MANIFEST_INVALID,
  70   ERROR_MANIFEST_CHANGED,
  71   ERROR_MANIFEST_OBSOLETE,
  72   ERROR_RESOURCE_FETCH,
  73   ERROR_QUOTA_EXCEEDED,
  74   ERROR_POLICY,
  75   ERROR_INTERNAL,  // this pretty much means failed to read/write disk

  enum ResultType {
    UPDATE_OK,
    DB_ERROR,
    DISKCACHE_ERROR,
    QUOTA_ERROR,
    REDIRECT_ERROR,
    MANIFEST_ERROR,
    NETWORK_ERROR,
    SERVER_ERROR,
  };

[jsbell, 2014/02/28 22:46:00]

Agreed, see discussion under ERROR_RESOURCE_FETCH

+};
+
 struct WEBKIT_STORAGE_COMMON_EXPORT AppCacheInfo {
   AppCacheInfo();
   ~AppCacheInfo();
 
   GURL manifest_url;
   base::Time creation_time;
   base::Time last_update_time;
   base::Time last_access_time;
   int64 cache_id;
   int64 group_id;
@@ skipping 47 matching lines @@
   virtual void OnCacheSelected(
       int host_id, const appcache::AppCacheInfo& info) = 0;
   virtual void OnStatusChanged(const std::vector<int>& host_ids,
                                Status status) = 0;
   virtual void OnEventRaised(const std::vector<int>& host_ids,
                              EventID event_id) = 0;
   virtual void OnProgressEventRaised(const std::vector<int>& host_ids,
                                      const GURL& url,
                                      int num_total, int num_complete) = 0;
   virtual void OnErrorEventRaised(const std::vector<int>& host_ids,
-                                  const std::string& message) = 0;
+                                  const std::string& message,
+                                  appcache::ErrorReason reason,
+                                  const GURL& url,
+                                  int status) = 0;
   virtual void OnContentBlocked(int host_id,
                                 const GURL& manifest_url) = 0;
   virtual void OnLogMessage(int host_id, LogLevel log_level,
                             const std::string& message) = 0;
   virtual ~AppCacheFrontend() {}
 };
 
 // Interface used by frontend (renderer) to talk to backend (browser-process).
 class WEBKIT_STORAGE_COMMON_EXPORT AppCacheBackend {
  public:
@@ skipping 39 matching lines @@
 WEBKIT_STORAGE_COMMON_EXPORT bool IsMethodSupported(const std::string& method);
 WEBKIT_STORAGE_COMMON_EXPORT bool IsSchemeAndMethodSupported(
     const net::URLRequest* request);
 
 WEBKIT_STORAGE_COMMON_EXPORT extern const base::FilePath::CharType
     kAppCacheDatabaseName[];
 
 }  // namespace
 
 #endif  // WEBKIT_COMMON_APPCACHE_APPCACHE_INTERFACES_H_