Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1649023002: Add flag to disable mmap in all sql connection in work build (Closed)

Created:
4 years, 10 months ago by Yaron
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Add flag to disable mmap in all sql connection in work build Work Chrome runs in environment without a proper mmap support. Disable it for all work chrome. BUG=554269 TBR=shess@chromium.org,vichang@chromium.org Review URL: https://codereview.chromium.org/1637683003 Cr-Commit-Position: refs/heads/master@{#372179} (cherry picked from commit 7ce37c1ec34e33f7e2c4b87341f16885942c3e5c) Committed: https://chromium.googlesource.com/chromium/src/+/bf25518ef370249de01768be568914e14fbdde5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeVersionInfo.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/feature_utilities.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M sql/connection.h View 1 chunk +4 lines, -1 line 0 comments Download
M sql/connection.cc View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Yaron
Committed patchset #1 (id:1) manually as bf25518ef370249de01768be568914e14fbdde5a (presubmit successful).
4 years, 10 months ago (2016-01-29 18:32:56 UTC) #2
Scott Hess - ex-Googler
4 years, 10 months ago (2016-01-29 18:36:41 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698