Add flag to disable mmap in all sql connection

Add flag to disable mmap in all sql connection in work build

Work Chrome runs in environment without a proper mmap support.
Disable it for all work chrome.

BUG=554269
Committed: https://crrev.com/7ce37c1ec34e33f7e2c4b87341f16885942c3e5c
Cr-Commit-Position: refs/heads/master@{#372179}

[vichang1, 2016-01-26 20:27:22]

vichang@chromium.org changed reviewers:
+ shess@chromium.org, yfriedman@chromium.org

[vichang1, 2016-01-26 20:27:23]

yfriedman@chromium.org: Please review changes in 

shess@chromium.org: Please review changes in

[Scott Hess - ex-Googler, 2016-01-26 21:51:08]

https://codereview.chromium.org/1637683003/diff/1/sql/connection.cc
File sql/connection.cc (right):

https://codereview.chromium.org/1637683003/diff/1/sql/connection.cc#newcode46
sql/connection.cc:46: bool mmap_disabled_default = false;
Probably needs to be g_mmap_disabled_default, I think.

[vichang1, 2016-01-27 15:19:16]

https://codereview.chromium.org/1637683003/diff/1/sql/connection.cc
File sql/connection.cc (right):

https://codereview.chromium.org/1637683003/diff/1/sql/connection.cc#newcode46
sql/connection.cc:46: bool mmap_disabled_default = false;
On 2016/01/26 21:51:08, Scott Hess wrote:
> Probably needs to be g_mmap_disabled_default, I think.

done.

[Yaron, 2016-01-27 16:10:47]

https://codereview.chromium.org/1637683003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
(right):

https://codereview.chromium.org/1637683003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:189:
mApplication.initializeProcessSync();
I think this is just confusing and too vague so likely to get misused.
Additionally, you can specify that this function runs async (first parameter)
but this happens regardless. On top of that, we're actively trying to trim down
our Application classes and not add more code to them. For these reasons, I
don't think this abstraction makes sense. I would sooner rather you just hack it
into here for work, honestly even if that isn't ideal.

Alternatively, ChromeMainDelegateAndroid::BasicStartupComplete would be another
place you could synchronously apply this call.

[vichang1, 2016-01-27 17:39:58]

On 2016/01/27 16:10:47, Yaron wrote:
>
https://codereview.chromium.org/1637683003/diff/20001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
> (right):
> 
>
https://codereview.chromium.org/1637683003/diff/20001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:189:
> mApplication.initializeProcessSync();
> I think this is just confusing and too vague so likely to get misused.
> Additionally, you can specify that this function runs async (first parameter)
> but this happens regardless. On top of that, we're actively trying to trim
down
> our Application classes and not add more code to them. For these reasons, I
> don't think this abstraction makes sense. I would sooner rather you just hack
it
> into here for work, honestly even if that isn't ideal.
> 
> Alternatively, ChromeMainDelegateAndroid::BasicStartupComplete would be
another
> place you could synchronously apply this call.

Done.

[Yaron, 2016-01-27 19:04:43]

https://codereview.chromium.org/1637683003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
(right):

https://codereview.chromium.org/1637683003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:191:
if ("com.chrome.work".equals(mApplication.getPackageName())) {
Use ChromeVersionInfo:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/jav...

[vichang1, 2016-01-28 17:34:52]

https://codereview.chromium.org/1637683003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
(right):

https://codereview.chromium.org/1637683003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java:191:
if ("com.chrome.work".equals(mApplication.getPackageName())) {
On 2016/01/27 19:04:43, Yaron wrote:
> Use ChromeVersionInfo:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/jav...

Done.

[vichang1, 2016-01-28 17:36:53]

Description was changed from

==========
Add flag to disable mmap in all sql connection

BUG=554269
==========

to

==========
Add flag to disable mmap in all sql connection

BUG=554269
==========

[vichang1, 2016-01-28 17:37:31]

Description was changed from

==========
Add flag to disable mmap in all sql connection

BUG=554269
==========

to

==========
Add flag to disable mmap in all sql connection in work build
    
Work Chrome runs in environment without a proper mmap support.
Disable it for all work chrome.

BUG=554269
==========

[Yaron, 2016-01-28 17:42:31]

lgtm

[Scott Hess - ex-Googler, 2016-01-28 20:33:01]

lgtm for sql/

[vichang1, 2016-01-28 20:47:33]

The CQ bit was checked by vichang@chromium.org

[commit-bot: I haz the power, 2016-01-28 20:48:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1637683003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1637683003/60001

[commit-bot: I haz the power, 2016-01-28 22:09:10]

Description was changed from

==========
Add flag to disable mmap in all sql connection in work build
    
Work Chrome runs in environment without a proper mmap support.
Disable it for all work chrome.

BUG=554269
==========

to

==========
Add flag to disable mmap in all sql connection in work build
    
Work Chrome runs in environment without a proper mmap support.
Disable it for all work chrome.

BUG=554269
==========

[commit-bot: I haz the power, 2016-01-28 22:09:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-28 22:10:02]

Description was changed from

==========
Add flag to disable mmap in all sql connection in work build
    
Work Chrome runs in environment without a proper mmap support.
Disable it for all work chrome.

BUG=554269
==========

to

==========
Add flag to disable mmap in all sql connection in work build

Work Chrome runs in environment without a proper mmap support.
Disable it for all work chrome.

BUG=554269

Committed: https://crrev.com/7ce37c1ec34e33f7e2c4b87341f16885942c3e5c
Cr-Commit-Position: refs/heads/master@{#372179}
==========

[commit-bot: I haz the power, 2016-01-28 22:10:03]

Patchset 4 (id:??) landed as
https://crrev.com/7ce37c1ec34e33f7e2c4b87341f16885942c3e5c
Cr-Commit-Position: refs/heads/master@{#372179}