Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1649003002: Use StylePath instead of (Path)StyleMotionPath (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StylePath instead of (Path)StyleMotionPath Replace uses of PathStyleMotionPath with StylePath and remove the former as well as the StyleMotionPath base-class. The methods length() and isClosed() are transferred to StylePath. Pass const CSSValue& to StyleBuilderConverter::convertPath (fixup to https://codereview.chromium.org/1545713003) necessitating mutability. Convert motion-path style building to use a converter. BUG=535429 Committed: https://crrev.com/7b3f2bb9e1638f6a5c6189a484c6e63f329a18da Cr-Commit-Position: refs/heads/master@{#372643}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -165 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPathValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPathValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 1 chunk +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 chunks +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 4 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 3 chunks +3 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/core/style/PathStyleMotionPath.h View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/Source/core/style/PathStyleMotionPath.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleMotionData.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleMotionData.cpp View 1 2 chunks +1 line, -6 lines 0 comments Download
D third_party/WebKit/Source/core/style/StyleMotionPath.h View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/style/StylePath.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StylePath.cpp View 2 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Path.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Path.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
fs
fmalita: could you take a look at the platform/ bits? Feel free to leave the ...
4 years, 10 months ago (2016-01-29 18:41:56 UTC) #2
f(malita)
On 2016/01/29 18:41:56, fs wrote: > fmalita: could you take a look at the platform/ ...
4 years, 10 months ago (2016-01-29 19:52:20 UTC) #3
Timothy Loh
lgtm
4 years, 10 months ago (2016-01-31 23:48:08 UTC) #4
Eric Willigers
lgtm
4 years, 10 months ago (2016-02-01 00:28:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649003002/1
4 years, 10 months ago (2016-02-01 09:54:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/124405) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-01 09:56:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649003002/20001
4 years, 10 months ago (2016-02-01 11:46:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-01 11:52:41 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 11:53:45 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b3f2bb9e1638f6a5c6189a484c6e63f329a18da
Cr-Commit-Position: refs/heads/master@{#372643}

Powered by Google App Engine
This is Rietveld 408576698