Add StylePath and use it to store 'd' in ComputedStyle

Add StylePath and use it to store 'd' in ComputedStyle

This adds a new class StylePath, that wraps a SVGPathByteStream and a
Path to be used when painting et.c. Create a StylePath on-demand from
CSSPathValue, and then cache the resulting value.
This allows sharing the various levels of path-data between different
instances/elements. It also avoids eagerly constructing the Path object
at setAttribute-time.
To be able to achieve this, SVGPathByteStream is made to be reference-
counted.

BUG=535429
Committed: https://crrev.com/f94944ad723e8a0cbee71258960394d17f32adef
Cr-Commit-Position: refs/heads/master@{#368320}

[fs, 2015-12-23 14:35:59]

Description was changed from

==========
StylePath
==========

to

==========
Add StylePath and use it to store 'd' in ComputedStyle

This adds a new class StylePath, that wraps a SVGPathByteStream and a
Path to be used when painting et.c. Create a StylePath on-demand from
CSSPathValue, and then cache the resulting value.
This allows sharing the various levels of path-data between different
instances/elements.
To be able to achieve this, SVGPathByteStream is made to be reference-
counted.

BUG=535429
==========

[fs, 2015-12-23 15:00:19]

Description was changed from

==========
Add StylePath and use it to store 'd' in ComputedStyle

This adds a new class StylePath, that wraps a SVGPathByteStream and a
Path to be used when painting et.c. Create a StylePath on-demand from
CSSPathValue, and then cache the resulting value.
This allows sharing the various levels of path-data between different
instances/elements.
To be able to achieve this, SVGPathByteStream is made to be reference-
counted.

BUG=535429
==========

to

==========
Add StylePath and use it to store 'd' in ComputedStyle

This adds a new class StylePath, that wraps a SVGPathByteStream and a
Path to be used when painting et.c. Create a StylePath on-demand from
CSSPathValue, and then cache the resulting value.
This allows sharing the various levels of path-data between different
instances/elements. It also avoids eagerly constructing the Path object
at setAttribute-time.
To be able to achieve this, SVGPathByteStream is made to be reference-
counted.

BUG=535429
==========

[fs, 2016-01-07 14:02:59]

fs@opera.com changed reviewers:
+ ericwilligers@chromium.org, pdr@chromium.org

[fs, 2016-01-07 14:03:00]

Something someone just couldn't leave alone...

Hopefully this doesn't add complication to the AnimatablePath -> <interpolation
type> (IIUC) transition.

Presumably other *Style*Path user/implementations could be migrated to this type
(haven't looked deeper into it though), but that's a story for another CL.

[pdr., 2016-01-07 19:47:01]

LGTM! It's belated, but a nice christmas present :)

Please wait for Eric's LGTM as well.

https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/StylePath.h (right):

https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/StylePath.h:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
2016!

[fs, 2016-01-07 20:06:15]

On 2016/01/07 at 19:47:01, pdr wrote:
> LGTM! It's belated, but a nice christmas present :)

Well, I did actually intend for it to be, but...

> Please wait for Eric's LGTM as well.
> 
>
https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/style/StylePath.h (right):
> 
>
https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/style/StylePath.h:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
> 2016!

At least I can use the excuse that it was the right year when I first uploaded
it ;-)

[Eric Willigers, 2016-01-08 11:58:58]

lgtm with nit

https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSPathValue.h (right):

https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPathValue.h:36: explicit
CSSPathValue(PassRefPtr<SVGPathByteStream>, StylePath*);
No need for explicit as we have more than one argument.

[fs, 2016-01-08 12:14:27]

https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSPathValue.h (right):

https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPathValue.h:36: explicit
CSSPathValue(PassRefPtr<SVGPathByteStream>, StylePath*);
On 2016/01/08 at 11:58:58, Eric Willigers wrote:
> No need for explicit as we have more than one argument.

Removed.

https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/StylePath.h (right):

https://codereview.chromium.org/1545713003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/StylePath.h:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/01/07 at 19:47:01, pdr wrote:
> 2016!

Fixed.

[fs, 2016-01-08 13:23:53]

The CQ bit was checked by fs@opera.com

[fs, 2016-01-08 13:23:54]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/1545713003/#ps60001
(title: "2015->2016; Remove unnecessary explicit.")

[commit-bot: I haz the power, 2016-01-08 13:24:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545713003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545713003/60001

[commit-bot: I haz the power, 2016-01-08 13:29:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-08 13:30:50]

Description was changed from

==========
Add StylePath and use it to store 'd' in ComputedStyle

This adds a new class StylePath, that wraps a SVGPathByteStream and a
Path to be used when painting et.c. Create a StylePath on-demand from
CSSPathValue, and then cache the resulting value.
This allows sharing the various levels of path-data between different
instances/elements. It also avoids eagerly constructing the Path object
at setAttribute-time.
To be able to achieve this, SVGPathByteStream is made to be reference-
counted.

BUG=535429
==========

to

==========
Add StylePath and use it to store 'd' in ComputedStyle

This adds a new class StylePath, that wraps a SVGPathByteStream and a
Path to be used when painting et.c. Create a StylePath on-demand from
CSSPathValue, and then cache the resulting value.
This allows sharing the various levels of path-data between different
instances/elements. It also avoids eagerly constructing the Path object
at setAttribute-time.
To be able to achieve this, SVGPathByteStream is made to be reference-
counted.

BUG=535429

Committed: https://crrev.com/f94944ad723e8a0cbee71258960394d17f32adef
Cr-Commit-Position: refs/heads/master@{#368320}
==========

[commit-bot: I haz the power, 2016-01-08 13:30:51]

Patchset 4 (id:??) landed as
https://crrev.com/f94944ad723e8a0cbee71258960394d17f32adef
Cr-Commit-Position: refs/heads/master@{#368320}