Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1648813002: [Sync] Renaming client key to client tag. (Closed)

Created:
4 years, 10 months ago by skym
Modified:
4 years, 10 months ago
Reviewers:
maxbogue, Gang Wu, pavely
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Renaming client key to client tag. BUG=582257 Committed: https://crrev.com/dfa1e3d0ff7add8a016241130e01ce00c5fcce43 Cr-Commit-Position: refs/heads/master@{#372216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -69 lines) Patch
M components/sync_driver/device_info_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/device_info_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/api/data_batch.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/api/entity_change.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/api/entity_change.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M sync/api/model_type_change_processor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/api/model_type_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/model_type_entity.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/model_type_entity_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/data_batch_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/internal_api/public/data_batch_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M sync/internal_api/public/data_batch_impl_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M sync/internal_api/public/model_type_entity.h View 3 chunks +5 lines, -5 lines 0 comments Download
M sync/internal_api/public/shared_model_type_processor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/test/fake_model_type_service.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/shared_model_type_processor.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M sync/internal_api/test/fake_model_type_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
skym
Zero logic change, just renaming key to tag.
4 years, 10 months ago (2016-01-28 23:22:16 UTC) #3
pavely
lgtm
4 years, 10 months ago (2016-01-28 23:33:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648813002/1
4 years, 10 months ago (2016-01-28 23:46:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 00:18:21 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 00:19:32 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dfa1e3d0ff7add8a016241130e01ce00c5fcce43
Cr-Commit-Position: refs/heads/master@{#372216}

Powered by Google App Engine
This is Rietveld 408576698