Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: sync/internal_api/public/data_batch_impl.h

Issue 1648813002: [Sync] Renaming client key to client tag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/model_type_entity_unittest.cc ('k') | sync/internal_api/public/data_batch_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/data_batch_impl.h
diff --git a/sync/internal_api/public/data_batch_impl.h b/sync/internal_api/public/data_batch_impl.h
index 9313310f420f942b60725f86f25c08312c2c2f31..575377fa54f6cd47f57f1638e7468cb15c7e8f43 100644
--- a/sync/internal_api/public/data_batch_impl.h
+++ b/sync/internal_api/public/data_batch_impl.h
@@ -21,24 +21,24 @@ namespace syncer_v2 {
// An implementation of DataBatch that's purpose is to transfer ownership of
// EntityData objects. As soon as this batch recieves the EntityData, it owns
// them until Next() is invoked, when it gives up ownerhsip. Because a vector
-// is used internally, this impl is unaware when duplcate client_keys are used,
+// is used internally, this impl is unaware when duplcate client_tags are used,
// and it is the caller's job to avoid this.
class SYNC_EXPORT DataBatchImpl : public DataBatch {
public:
DataBatchImpl();
~DataBatchImpl() override;
- // Takes ownership of the data tied to a given key used for storage. Put
- // should be called at most once for any given client_key. Data will be
+ // Takes ownership of the data tied to a given tag used for storage. Put
+ // should be called at most once for any given client_tag. Data will be
// readable in the same order that they are put into the batch.
- void Put(const std::string& client_key, scoped_ptr<EntityData> entity_data);
+ void Put(const std::string& client_tag, scoped_ptr<EntityData> entity_data);
// DataBatch implementation.
bool HasNext() const override;
- KeyAndData Next() override;
+ TagAndData Next() override;
private:
- std::vector<KeyAndData> key_data_pairs_;
+ std::vector<TagAndData> tag_data_pairs_;
size_t read_index_ = 0;
DISALLOW_COPY_AND_ASSIGN(DataBatchImpl);
« no previous file with comments | « sync/internal_api/model_type_entity_unittest.cc ('k') | sync/internal_api/public/data_batch_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698