Issue 1648793006: Merge to XFA: Fix botched "CC:" parameter passing in JS_DocmailForm().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1648793006: Merge to XFA: Fix botched "CC:" parameter passing in JS_DocmailForm(). (Closed)

Created:
4 years, 10 months ago by Tom Sepez

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix botched "CC:" parameter passing in JS_DocmailForm(). Original Review URL: https://codereview.chromium.org/1645413002 . (cherry picked from commit 6902db5cbaf0afb8f2cb4df325e1a4e7d6acd53f) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e5fbd7a170257b455f6ea8c94f71e827e6c3bb8d

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -66 lines)			Patch
M	fpdfsdk/src/fsdk_mgr.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	2 chunks	+32 lines, -49 lines	0 comments	Download
M	samples/pdfium_test.cc	View	2 chunks	+16 lines, -0 lines	0 comments	Download
A +	testing/resources/javascript/app_mailmsg.in	View	1 chunk	+16 lines, -15 lines	0 comments	Download
A	testing/resources/javascript/app_mailmsg_expected.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as e5fbd7a170257b455f6ea8c94f71e827e6c3bb8d (presubmit successful).

4 years, 10 months ago (2016-01-30 01:05:12 UTC) #3

Message was sent while issue was closed.

lgtm