Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1645413002: Fix botched "CC:" parameter passing in JS_DocmailForm(). (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix botched "CC:" parameter passing in JS_DocmailForm(). Moved onto JS_ExpandKeywordParams(), and added a test which showed the failure to pass all the data back to the embedder. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6902db5cbaf0afb8f2cb4df325e1a4e7d6acd53f

Patch Set 1 #

Patch Set 2 : 80 cols. #

Total comments: 3

Patch Set 3 : Rebase. #

Patch Set 4 : Rename back to "params". #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -66 lines) Patch
M fpdfsdk/src/fsdk_mgr.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 2 3 2 chunks +32 lines, -49 lines 0 comments Download
M samples/pdfium_test.cc View 2 chunks +16 lines, -0 lines 0 comments Download
A + testing/resources/javascript/app_mailmsg.in View 1 1 chunk +16 lines, -15 lines 0 comments Download
A testing/resources/javascript/app_mailmsg_expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Lei, for review.
4 years, 10 months ago (2016-01-29 18:52:00 UTC) #2
Tom Sepez
Lei, for review. https://codereview.chromium.org/1645413002/diff/20001/fpdfsdk/src/fsdk_mgr.cpp File fpdfsdk/src/fsdk_mgr.cpp (right): https://codereview.chromium.org/1645413002/diff/20001/fpdfsdk/src/fsdk_mgr.cpp#newcode347 fpdfsdk/src/fsdk_mgr.cpp:347: bsTo.ReleaseBuffer(); nit: pointless. We'll get these ...
4 years, 10 months ago (2016-01-29 18:55:50 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1645413002/diff/20001/fpdfsdk/src/javascript/app.cpp File fpdfsdk/src/javascript/app.cpp (right): https://codereview.chromium.org/1645413002/diff/20001/fpdfsdk/src/javascript/app.cpp#newcode533 fpdfsdk/src/javascript/app.cpp:533: const std::vector<CJS_Value>& originalParams, Can you change the header ...
4 years, 10 months ago (2016-01-30 00:44:11 UTC) #4
Tom Sepez
https://codereview.chromium.org/1645413002/diff/20001/fpdfsdk/src/javascript/app.cpp File fpdfsdk/src/javascript/app.cpp (right): https://codereview.chromium.org/1645413002/diff/20001/fpdfsdk/src/javascript/app.cpp#newcode533 fpdfsdk/src/javascript/app.cpp:533: const std::vector<CJS_Value>& originalParams, On 2016/01/30 00:44:11, Lei Zhang wrote: ...
4 years, 10 months ago (2016-01-30 00:55:03 UTC) #5
Tom Sepez
4 years, 10 months ago (2016-01-30 00:55:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
6902db5cbaf0afb8f2cb4df325e1a4e7d6acd53f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698