Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1648773002: SaveFlags begone! (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -137 lines) Patch
M include/core/SkCanvas.h View 5 chunks +0 lines, -89 lines 1 comment Download
M src/core/SkCanvas.cpp View 2 chunks +0 lines, -44 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
f(malita)
https://codereview.chromium.org/1648773002/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (left): https://codereview.chromium.org/1648773002/diff/1/include/core/SkCanvas.h#oldcode1375 include/core/SkCanvas.h:1375: static SaveLayerFlags LegacySaveFlagsToSaveLayerFlags(uint32_t legacySaveFlags); I think we can relocate ...
4 years, 10 months ago (2016-01-28 20:42:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648773002/1
4 years, 10 months ago (2016-01-28 20:43:06 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-01-28 20:43:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/5826)
4 years, 10 months ago (2016-01-28 20:44:16 UTC) #7
robertphillips
lgtm
4 years, 10 months ago (2016-01-28 20:45:39 UTC) #8
reed1
I'm all choked up lgtm
4 years, 10 months ago (2016-01-28 21:06:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648773002/1
4 years, 10 months ago (2016-01-28 21:07:48 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 21:14:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/54d60293cecb384de5683d9bea925c97f6ed485b

Powered by Google App Engine
This is Rietveld 408576698