Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1636103002:
Remove SK_SUPPORT_LEGACY_SAVEFLAGS define on Android (Closed)
DescriptionRemove SK_SUPPORT_LEGACY_SAVEFLAGS define on Android
Android is the only platform still using SK_SUPPORT_LEGACY_SAVEFLAGS
(indirectly, due to SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG).
At this point it should be safe to remove the define.
R=djsollen@google.com,scroggo@google.com,reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1636103002
Committed: https://skia.googlesource.com/skia/+/4c5f1f611469b489297b1ce4f5dd0bc54cb5bb88
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
Description was changed from ========== Remove SK_SUPPORT_LEGACY_SAVEFLAGS define on Android Android is the only platform still using SK_SUPPORT_LEGACY_SAVEFLAGS (indirectly, due to SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG). At this point it should be safe to remove the define. R=djsollen@google.com,scroggo@google.com,reed@google.com ========== to ========== Remove SK_SUPPORT_LEGACY_SAVEFLAGS define on Android Android is the only platform still using SK_SUPPORT_LEGACY_SAVEFLAGS (indirectly, due to SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG). At this point it should be safe to remove the define. R=djsollen@google.com,scroggo@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
I verified that Android (master) still builds without the saveflags define. Once this CL rolls/sticks to Android master, we can finally delete all related code.
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636103002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636103002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-01-27 01:48 UTC
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636103002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full Skia committer
lgtm
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1636103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1636103002/1
Message was sent while issue was closed.
Description was changed from ========== Remove SK_SUPPORT_LEGACY_SAVEFLAGS define on Android Android is the only platform still using SK_SUPPORT_LEGACY_SAVEFLAGS (indirectly, due to SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG). At this point it should be safe to remove the define. R=djsollen@google.com,scroggo@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Remove SK_SUPPORT_LEGACY_SAVEFLAGS define on Android Android is the only platform still using SK_SUPPORT_LEGACY_SAVEFLAGS (indirectly, due to SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG). At this point it should be safe to remove the define. R=djsollen@google.com,scroggo@google.com,reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/4c5f1f611469b489297b1ce4f5dd0bc54cb5bb88 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/4c5f1f611469b489297b1ce4f5dd0bc54cb5bb88 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
