mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl - Issue 164873002: Fix bug with using enums as default values in mojom. We were previously

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl

Issue 164873002: Fix bug with using enums as default values in mojom. We were previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/apps/js/bindings/sample_service_unittests.js ('K') | « mojo/apps/js/bindings/sample_service_unittests.js ('k') | mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl

diff --git a/mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl b/mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl

index 08c12c59e61e26496fff55a03592b9ea23b7eae9..1c80eeee058d2ce80be91cb2abd661b9dc4d6637 100644

--- a/mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl

+++ b/mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl

@@ -1,7 +1,7 @@

enum {{enum.name}} {

{%- for field in enum.fields %}

{%- if field.value %}

- {{field.name}} = {{field.value}},

+ {{field.name}} = {{field.value|expression_to_text(module)}},

{%- else %}

{{field.name}},

{%- endif %}