Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1648683002: [Merge to 49] [Downloads] Avoid resetting SecureHash state across an interruption. (Closed)

Created:
4 years, 10 months ago by asanka
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

[Merge to 49] [Downloads] Avoid resetting SecureHash state across an interruption. DownloadFileImpl/BaseFile was causing the SecureHash object to be finalized when a download was interrupted. This caused the hash state to be incorrect and subsequently the hash resulting from resuming the download was also incorrect. BUG=7648 BUG=581164 Review URL: https://codereview.chromium.org/1591523002 Cr-Commit-Position: refs/heads/master@{#371428} (cherry picked from commit bdc7250e539a9f40f84fd157bc29481e5aac2bf8) Committed: https://chromium.googlesource.com/chromium/src/+/662aed60b889672f028f1c4b8a357d7f36348efd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
M content/browser/download/base_file.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/download/base_file.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 2 chunks +55 lines, -0 lines 0 comments Download
M content/browser/download/download_file_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
asanka
4 years, 10 months ago (2016-01-28 15:30:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
662aed60b889672f028f1c4b8a357d7f36348efd.

Powered by Google App Engine
This is Rietveld 408576698