Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1591523002: [Downloads] Avoid resetting SecureHash state across an interruption. (Closed)

Created:
4 years, 11 months ago by asanka
Modified:
4 years, 11 months ago
Reviewers:
svaldez
CC:
chromium-reviews, asanka, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Avoid resetting SecureHash state across an interruption. DownloadFileImpl/BaseFile was causing the SecureHash object to be finalized when a download was interrupted. This caused the hash state to be incorrect and subsequently the hash resulting from resuming the download was also incorrect. BUG=7648 BUG=581164 Committed: https://crrev.com/bdc7250e539a9f40f84fd157bc29481e5aac2bf8 Cr-Commit-Position: refs/heads/master@{#371428}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
M content/browser/download/base_file.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/download/base_file.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 1 2 chunks +55 lines, -0 lines 0 comments Download
M content/browser/download/download_file_impl.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
asanka
4 years, 11 months ago (2016-01-25 22:18:13 UTC) #5
svaldez
lgtm
4 years, 11 months ago (2016-01-25 22:31:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1591523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1591523002/20001
4 years, 11 months ago (2016-01-26 01:03:16 UTC) #8
commit-bot: I haz the power
Failed to commit the patch.
4 years, 11 months ago (2016-01-26 01:58:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1591523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1591523002/20001
4 years, 11 months ago (2016-01-26 02:29:33 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 02:37:54 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 02:39:25 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bdc7250e539a9f40f84fd157bc29481e5aac2bf8
Cr-Commit-Position: refs/heads/master@{#371428}

Powered by Google App Engine
This is Rietveld 408576698