third_party/WebKit/Source/core/layout/line/InlineFlowBox.h - Issue 1648573002: Transition to explicit constructors in LayoutUnit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

Issue 1648573002: Transition to explicit constructors in LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove int constructors for size/point... they result in incorrect conversions until LayoutUnit is … Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

index e03f8aab461eca36b77ae61deac4b99fa24ffa40..ac1770b30476cc93bd594d68520ccbaae9610784 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

@@ -130,13 +130,13 @@ public:

LayoutUnit marginLogicalLeft() const

{

if (!includeLogicalLeftEdge())

- return 0;

+ return LayoutUnit();

return isHorizontal() ? boxModelObject().marginLeft() : boxModelObject().marginTop();

}

LayoutUnit marginLogicalRight() const

{

if (!includeLogicalRightEdge())

- return 0;

+ return LayoutUnit();

return isHorizontal() ? boxModelObject().marginRight() : boxModelObject().marginBottom();

}

int borderLogicalLeft() const