third_party/WebKit/Source/core/layout/LayoutVideo.cpp - Issue 1648573002: Transition to explicit constructors in LayoutUnit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutVideo.cpp

Issue 1648573002: Transition to explicit constructors in LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove int constructors for size/point... they result in incorrect conversions until LayoutUnit is … Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutVideo.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp b/third_party/WebKit/Source/core/layout/LayoutVideo.cpp

index 7921851788b9f639545b4d158ef0e7f1e7d410bd..15af32e8d04e4da0ca7b3862d27c21fa9cf8c9ba 100644

--- a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutVideo.cpp

@@ -104,7 +104,7 @@ LayoutSize LayoutVideo::calculateIntrinsicSize()

// size to 300x1 the video will resize itself in these cases, and audio will

// have the correct height (it needs to be > 0 for controls to layout properly).

if (video->ownerDocument() && video->ownerDocument()->isMediaDocument())

- return LayoutSize(defaultSize().width(), 1);

+ return LayoutSize(defaultSize().width(), LayoutUnit(1));

return defaultSize();

}