third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h - Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h

Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h ('k') | third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h

index 6bbfdec0acc963a7ccd9394cc0a24ba63a32de02..0a7fe70d8e52eef95a2a2acaf28cbbf7431399cd 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h

@@ -135,10 +135,10 @@ private:

using AgentsMap = HashMap<int, V8DebuggerAgentImpl*>;

AgentsMap m_agentsMap;

bool m_breakpointsActivated;

- v8::UniquePersistent<v8::FunctionTemplate> m_breakProgramCallbackTemplate;

- v8::UniquePersistent<v8::Object> m_debuggerScript;

- v8::UniquePersistent<v8::Context> m_debuggerContext;

- v8::UniquePersistent<v8::FunctionTemplate> m_callFrameWrapperTemplate;

+ v8::Global<v8::FunctionTemplate> m_breakProgramCallbackTemplate;

+ v8::Global<v8::Object> m_debuggerScript;

+ v8::Global<v8::Context> m_debuggerContext;

+ v8::Global<v8::FunctionTemplate> m_callFrameWrapperTemplate;

v8::Local<v8::Object> m_executionState;

v8::Local<v8::Context> m_pausedContext;

bool m_runningNestedMessageLoop;